MINOR: fix typo, use createTopic instead waitForDeletion
#20054
+3
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
TaiJuWu
reviewed
Jun 27, 2025
Comment on lines
280
to
281
| admin.createTopics(List.of(new NewTopic(topic10, brokerSize, (short) brokerSize).configs(topicConfig))); | ||
| clusterInstance.waitTopicDeletion("topic10"); | ||
| clusterInstance.waitForTopic("topic10", brokerSize); |
There was a problem hiding this comment.
How about use clusterInstance.createTopic?
frankvicky
approved these changes
Jun 27, 2025
m1a2st
approved these changes
Jun 27, 2025
FrankYang0529
approved these changes
Jun 27, 2025
gongxuanzhang
changed the title
waitForTopic instead waitForDeletioncreateTopic instead waitForDeletion
Yunyung
approved these changes
Jun 27, 2025
TaiJuWu
approved these changes
Jun 27, 2025
chia7712
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ProducerFailureHandlingTestwe should use waitForTopic rather thanwaitForDeletion