-
Notifications
You must be signed in to change notification settings - Fork 14.5k
(WIP)KAFKA-9965/KAFKA-13303: RoundRobinPartitioner broken by KIP-480 #20170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jim0987795064
wants to merge
16
commits into
apache:trunk
Choose a base branch
from
jim0987795064:KAFKA-9965/KAFKA-13303-trunk-backport
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
(WIP)KAFKA-9965/KAFKA-13303: RoundRobinPartitioner broken by KIP-480 #20170
jim0987795064
wants to merge
16
commits into
apache:trunk
from
jim0987795064:KAFKA-9965/KAFKA-13303-trunk-backport
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partitioner.onNewBatch(topicB, testCluster, 1); | ||
assertEquals(7, partitioner.partition(topicA, null, null, null, null, testCluster)); | ||
assertEquals(8, partitioner.partition(topicA, null, null, null, null, testCluster)); | ||
assertEquals(1, partitioner.partition(topicB, null, null, null, null, testCluster)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great that this test verifies the next partition selected matches the enqueued value for each topic. Consider adding test cases for some edge cases, like empty queue and error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoundRobinPartitioner behaviour was broken by sticky partitioning (KIP-480).
This patch addresses the behavioural issue caused by the second call to
partition()
afteronNewBatch()
, in a predicatable and thread-safe manner.Unit tested by simulation of multiple threads producing to two topics with race conditions.
Changes:
Reasons: