KAFKA-19530 RemoteLogManager should record lag stats when remote storage is offline #20218
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
kamalcph
reviewed
Jul 23, 2025
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java
Outdated
Show resolved
Hide resolved
kamalcph
reviewed
Jul 23, 2025
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java
Outdated
Show resolved
Hide resolved
kamalcph
reviewed
Jul 23, 2025
| @@ -973,6 +973,9 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException | |||
| segmentIdsBeingCopied.add(segmentId); | |||
| try { | |||
| copyLogSegment(log, candidateLogSegment.logSegment, segmentId, candidateLogSegment.nextSegmentOffset); | |||
| } catch (RemoteStorageException e) { | |||
There was a problem hiding this comment.
can we catch all exception in the catch block and then throw it?
RemoteStorageException -> Exception
since copyLogSegment throws InterruptedException, ExecutionException, RemoteStorageException, IOException, and CustomMetadataSizeLimitExceededException:
catch (Exception e) {
recordLagStats(log);
throw e;
}
|
@m1a2st |
|
@kamalcph, Sorry for the late reply! I was traveling last week, but I'll go through your comments ASAP. |
kamalcph
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When remote storage is offline, then the segmentLag and bytesLag metrics
are not recorded. These metrics are useful to know the pending data to
upload when remote storage is down.
Reviewers: TaiJuWu [email protected], Kamal Chandraprakash
[email protected]