Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docusaurus.config.js to enable dark mode switch #209

Closed
wants to merge 1 commit into from

Conversation

asad-awadia
Copy link

Screenshot 2024-03-12 160504

@tisonkun
Copy link
Member

I remember we ever banned it because the homepage would have a dirty look (style incompatible)?

@git-hulk
Copy link
Member

git-hulk commented Mar 13, 2024

@tisonkun Yes, but it looks good for now(from my personal perspective).

image

@PragmaTwice
Copy link
Member

PragmaTwice commented Mar 13, 2024

image @tisonkun Yes, but it looks good for now(from my personal perspective).

Really good? I cannot understand your point. The home page looks really bad in dark mode:

  • The banner is still in light mode.
  • Buttons are still in light mode.
  • Namespace icon has a white rectangular frame.

@PragmaTwice
Copy link
Member

Sorry but we need a good overall solution of dark mode.

Not just enable the dark mode switch.

@asad-awadia
Copy link
Author

Sorry but we need a good overall solution of dark mode.

I will whip up an HLD for it :)

Perfection is the enemy of good and things can be added incrementally

But in all seriousness, the dark mode looks great for all pages - homepage looks off because the assets aren't dark mode but I can't update those

@git-hulk
Copy link
Member

git-hulk commented Mar 13, 2024

image @tisonkun Yes, but it looks good for now(from my personal perspective).

Really good? I cannot understand your point. The home page looks really bad in dark mode:

  • The banner is still in light mode.
  • Buttons are still in light mode.
  • Namespace icon has a white rectangular frame.

😭 Maybe I have a bad sense of web UI, so I think those inconsistent colors between them are good for me. Also the reason why I just mentioned that's my perspective.

@asad-awadia asad-awadia closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants