Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the KQIR intro blog post #223

Merged
merged 21 commits into from
Jun 2, 2024
Merged

Add the KQIR intro blog post #223

merged 21 commits into from
Jun 2, 2024

Conversation

PragmaTwice
Copy link
Member

Add the blog post "KQIR: a query engine for Apache Kvrocks that supports both SQL and RediSearch queries".

@PragmaTwice PragmaTwice requested review from git-hulk and tisonkun June 2, 2024 10:36
@git-hulk
Copy link
Member

git-hulk commented Jun 2, 2024

@PragmaTwice Thanks for your great article, the blog post is quite good to me.

I see the truncate line is before the Intro section, so it won't show any content in the blog post list. Not sure if it's expected, perhaps it will be better to show the introduction to let readers know a bit more about the post.

image

@PragmaTwice
Copy link
Member Author

Done.

tisonkun
tisonkun reviewed Jun 2, 2024
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool!

Finish the first review and leave some comments. Please ping me when all the comments are handled or addressed.

PragmaTwice and others added 15 commits June 2, 2024 23:40
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
603f867 
Co-authored-by: tison <[email protected]>
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
3e3a96f 
Co-authored-by: tison <[email protected]>
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
fab4510 
Co-authored-by: tison <[email protected]>
@PragmaTwice
fix
3847f71
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
cd14ea6 
Co-authored-by: tison <[email protected]>
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
91a4f69 
Co-authored-by: tison <[email protected]>
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
7e04a84 
Co-authored-by: tison <[email protected]>
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
a45aa77 
Co-authored-by: tison <[email protected]>
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
7eef94c 
Co-authored-by: tison <[email protected]>
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
ac47bba 
Co-authored-by: tison <[email protected]>
@PragmaTwice @tisonkun
Update blog/2024-06-02-kqir-query-engine/index.md
0843935 
Co-authored-by: tison <[email protected]>
@PragmaTwice
fix
c06700f
@PragmaTwice
fix
79cc71d
@PragmaTwice
add compliance
d19ffa8
@PragmaTwice
fix
58441ad
tisonkun
tisonkun approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your follow-up!

@PragmaTwice
Copy link
Member Author

Thank you for your suggestions!

@PragmaTwice PragmaTwice merged commit ea62d67 into main Jun 2, 2024
1 check passed
@PragmaTwice PragmaTwice deleted the kqir branch July 31, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @tisonkun