Fix comment

apache · Nov 11, 2024 · 9a6fab1 · 9a6fab1
1 parent 2f185a7
commit 9a6fab1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/storage/redis_db.cc b/src/storage/redis_db.cc
@@ -81,7 +81,7 @@ rocksdb::Status Database::ParseMetadata(RedisTypes types, Slice *bytes, Metadata
 // For example, bitmap supports reading string metadata and bitmap metadata.
 rocksdb::Status Database::ParseMetadataWithStats(RedisTypes types, Slice *bytes, Metadata *metadata) {
   auto s = ParseMetadata(types, bytes, metadata);
-  storage_->RecordStat(s.ok() ? engine::StatType::KeyspaceHits : engine::StatType::KeyspaceHits, 1);
+  storage_->RecordStat(s.ok() ? engine::StatType::KeyspaceHits : engine::StatType::KeyspaceMisses, 1);
   return s;
 }
 

diff --git a/src/types/redis_json.cc b/src/types/redis_json.cc
@@ -661,7 +661,7 @@ rocksdb::Status Json::DebugMemory(engine::Context &ctx, const std::string &user_
 }
 
 rocksdb::Status Json::Resp(engine::Context &ctx, const std::string &user_key, const std::string &path,
-                           std::vector<std::string> *results, RESP resp) {
+                           std::vector<std::stringParseMetadataWithStats> *results, RESP resp) {
   auto ns_key = AppendNamespacePrefix(user_key);
   JsonMetadata metadata;
   JsonValue json_val;
@@ -674,7 +674,7 @@ rocksdb::Status Json::Resp(engine::Context &ctx, const std::string &user_key, co
   return rocksdb::Status::OK();
 }
 
-rocksdb::Status Json::FromRawString(const std::string &value, JsonValue *result) {
+rocksdb::Status Json::FromRawString(std::string_view value, JsonValue *result) {
   Slice rest = value;
   JsonMetadata metadata;
   auto s = ParseMetadata({kRedisJson}, &rest, &metadata);

diff --git a/src/types/redis_json.h b/src/types/redis_json.h
@@ -82,7 +82,7 @@ class Json : public Database {
 
   rocksdb::Status Resp(engine::Context &ctx, const std::string &user_key, const std::string &path,
                        std::vector<std::string> *results, RESP resp);
-  static rocksdb::Status FromRawString(const std::string &value, JsonValue *result);
+  static rocksdb::Status FromRawString(std::string_view value, JsonValue *result);
 
  private:
   rocksdb::Status write(engine::Context &ctx, Slice ns_key, JsonMetadata *metadata, const JsonValue &json_val);