Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): support the FT.TAGVALS command #2564

Merged
merged 11 commits into from
Oct 4, 2024
Merged

feat(search): support the FT.TAGVALS command #2564

merged 11 commits into from
Oct 4, 2024

Conversation

jonathanc-n
Copy link
Contributor

Added FT.TagVals for search + tests

@jonathanc-n jonathanc-n mentioned this pull request Sep 30, 2024
Open
26 tasks
PragmaTwice
PragmaTwice reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me.

@jonathanc-n
Copy link
Contributor Author

@PragmaTwice Commited to change. Should be good to run workflow

@PragmaTwice
Copy link
Member

Could you check the CI failure to see if it can be fixed?

@jonathanc-n
Copy link
Contributor Author

@PragmaTwice CI, should be fixed. It was just incorrect return values for type mismatch.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@PragmaTwice PragmaTwice changed the title feat: Added FT.TAGVALS Command to Search feat(search): support the FT.TAGVALS command Oct 4, 2024
@PragmaTwice PragmaTwice merged commit 0a43bad into apache:unstable Oct 4, 2024
33 checks passed
@jonathanc-n jonathanc-n deleted the ft-tagvals-command branch October 4, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanc-n @PragmaTwice