Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
zwangsheng committed Oct 7, 2023
1 parent 3e4083d commit 107221b
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ALTER TABLE metadata ADD COLUMN priority int default 10;
ALTER TABLE metadata ADD COLUMN priority int default 10 NOT NULL;

CREATE INDEX metadata_priority_create_time_index ON metadata(priority, create_time);
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ CREATE TABLE metadata(
engine_state varchar(32), -- the engine application state
engine_error clob, -- the engine application diagnose
end_time bigint, -- the metadata end time
priority int DEFAULT 10, -- the application priority, high value means high priority
priority int DEFAULT 10 NOT NULL, -- the application priority, high value means high priority
peer_instance_closed boolean default FALSE -- closed by peer kyuubi instance
);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
SELECT '< KYUUBI-5327: Introduce priority in metadata' AS ' ';

ALTER TABLE metadata ADD COLUMN priority int default 10 COMMENT 'the application priority, high value means high priority';
ALTER TABLE metadata ADD COLUMN priority int default 10 NOT NULL COMMENT 'the application priority, high value means high priority';

-- In mysql 5.7, A key_part specification can end with ASC or DESC.
-- In MySQL 5.7, A key_part specification can end with ASC or DESC.
-- These keywords are permitted for future extensions for specifying ascending or descending index value storage.
-- Currently, they are parsed but ignored; index values are always stored in ascending order.
-- In mysql 8 this can take effect and this index will be hit if query order by priority DESC, create_time ASC.
-- In MySQL 8 this can take effect and this index will be hit if query order by priority DESC, create_time ASC.
-- See more detail in:
-- https://dev.mysql.com/doc/refman/8.0/en/index-hints.html
-- https://dev.mysql.com/doc/refman/8.0/en/create-index.html
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ CREATE TABLE IF NOT EXISTS metadata(
engine_state varchar(32) COMMENT 'the engine application state',
engine_error mediumtext COMMENT 'the engine application diagnose',
end_time bigint COMMENT 'the metadata end time',
priority int DEFAULT 10 COMMENT 'the application priority, high value means high priority',
priority int DEFAULT 10 NOT NULL COMMENT 'the application priority, high value means high priority',
peer_instance_closed boolean default '0' COMMENT 'closed by peer kyuubi instance',
UNIQUE INDEX unique_identifier_index(identifier),
INDEX user_name_index(user_name),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ CREATE TABLE IF NOT EXISTS metadata(
engine_state varchar(32), -- the engine application state
engine_error mediumtext, -- the engine application diagnose
end_time bigint, -- the metadata end time
priority INTEGER DEFAULT 10, -- the application priority, high value means high priority
priority INTEGER DEFAULT 10 NOT NULL, -- the application priority, high value means high priority
peer_instance_closed boolean default '0' -- closed by peer kyuubi instance
);

Expand Down

0 comments on commit 107221b

Please sign in to comment.