Skip to content

Commit

Permalink
[KYUUBI #5802] [DOC] Add scala-2.13 as supported Scala profile to the…
Browse files Browse the repository at this point in the history
… docs of building from source

# 🔍 Description
## Issue References 🔗

As described.

## Describe Your Solution 🔧

Add docs for spark-3.4 and spark-3.5 as supported Spark profiles.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️
No related docs.

#### Behavior With This Pull Request 🎉
<img width="766" alt="image" src="https://github.com/apache/kyuubi/assets/1935105/a217b939-f97a-4176-b320-a047eb142609">

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [x] I have performed a self-review
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes #5802 from bowenliang123/docs-scala-213.

Closes #5802

d734207 [liangbowen] add scala-2.13 profile to the docs of building from code

Authored-by: liangbowen <[email protected]>
Signed-off-by: wforget <[email protected]>
  • Loading branch information
bowenliang123 authored and wForget committed Dec 5, 2023
1 parent 762ccd8 commit 3ff4593
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions docs/contributing/code/building.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,19 @@ Since v1.1.0, Kyuubi support building with different Spark profiles,
| -Pspark-3.4 || 1.8.0 |
| -Pspark-3.5 | | 1.8.0 |

## Building Kyuubi Against Different Scala Versions

Since v1.8.0, Kyuubi support building with different Scala profile. Currently, Kyuubi supports building with Scala 2.12 and 2.13, while Scala 2.12 by default.

| Profile | Default | Since |
|--------------|---------|-------|
| (Scala 2.12) || - |
| -Pscala-2.13 | | 1.8.0 |

Please activate `scala-2.13` profile when Scala 2.13 support is needed. The GA tests have covered integration test with the Kyuubi server, engines and related plugins, while the Flink engine and it's integration tests are not included for the reason that Flink does not support Scala 2.13 yet and will pull out client support for Scala.

For the Scala version for Spark engines, the server will look up the `SPARK_SCALA_VERSION` system environment variable first, and then the Scala version of the server compiled with if the former one not set. For the Scala version for other engines, the server will use the Scala version of the server compiled with.

## Building With Apache dlcdn Site

By default, we use `https://archive.apache.org/dist/` to download the built-in release packages of engines,
Expand Down

0 comments on commit 3ff4593

Please sign in to comment.