Skip to content

Commit

Permalink
[KYUUBI #5509][FOLLOWUP] JDBC IT should always depends on kyuubi-hive…
Browse files Browse the repository at this point in the history
…-jdbc-shaded

# 🔍 Description
## Issue References 🔗

`build/dist` is going to fail without profile `-Pjdbc-shaded` after bumping a new version.

## Describe Your Solution 🔧

Making the JDBC IT module always depends on `kyuubi-hive-jdbc-shaded`, to ensure the shaded JDBC is packaged before the JDBC IT module performs copy jars.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Bump a new version, then perform making the distribution.
```
build/mvn versions:set -DgenerateBackupPoms=false -DnewVersion="1.9.1-SNAPSHOT"
build/dist --spark-provided --hive-provided --flink-provided
```
Before, failed with
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:copy (copy) on project kyuubi-jdbc-it_2.12: Unable to find/resolve artifact.: Could not find artifact org.apache.kyuubi:kyuubi-hive-jdbc-shaded🫙1.9.1-SNAPSHOT in aliyun-apache-snapshots (https://maven.aliyun.com/repository/apache-snapshots/) -> [Help 1]
```

After, everything goes well.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6135 from pan3793/impala-folowup.

Closes #5509

12f600d [Cheng Pan] [KYUUBI #5509][FOLLOWUP] JDBC IT should always depends on kyuubi-hive-jdbc-shaded

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
pan3793 committed Mar 7, 2024
1 parent f1cf1e4 commit 5df34e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion integration-tests/kyuubi-jdbc-it/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@

<dependency>
<groupId>org.apache.kyuubi</groupId>
<artifactId>${hive.jdbc.artifact}</artifactId>
<artifactId>kyuubi-hive-jdbc-shaded</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
Expand Down

0 comments on commit 5df34e4

Please sign in to comment.