Skip to content

Commit

Permalink
[KYUUBI #5782] Flink Engine GetInfo support CLI_ODBC_KEYWORDS
Browse files Browse the repository at this point in the history
# 🔍 Description
## Issue References 🔗

This PR aims to support `CLI_ODBC_KEYWORDS` on flink engine to avoid #2637

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests
Adjusted existing test #org.apache.kyuubi.it.flink.operation.FlinkOperationSuite

---

# Checklists
## 📝 Author Self Checklist

- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [x] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [x] Pull request title is okay.
- [x] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes #5782 from Yikf/flink-CLI_ODBC_KEYWORDS.

Closes #5782

ef0dc04 [yikaifei] Flink GetInfo support CLI_ODBC_KEYWORDS

Authored-by: yikaifei <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
yikf authored and pan3793 committed Nov 27, 2023
1 parent 933978e commit 67bf8e1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ class FlinkSessionImpl(
case TGetInfoType.CLI_SERVER_NAME | TGetInfoType.CLI_DBMS_NAME =>
TGetInfoValue.stringValue("Apache Flink")
case TGetInfoType.CLI_DBMS_VER => TGetInfoValue.stringValue(EnvironmentInformation.getVersion)
case TGetInfoType.CLI_ODBC_KEYWORDS => TGetInfoValue.stringValue("Unimplemented")
case _ => throw KyuubiSQLException(s"Unrecognized GetInfoType value: $infoType")
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ class FlinkOperationSuite extends WithKyuubiServerAndFlinkMiniCluster
req.setSessionHandle(handle)
req.setInfoType(TGetInfoType.CLI_DBMS_NAME)
assert(client.GetInfo(req).getInfoValue.getStringValue === "Apache Flink")
req.setInfoType(TGetInfoType.CLI_ODBC_KEYWORDS)
assert(client.GetInfo(req).getInfoValue.getStringValue === "Unimplemented")
}
}
}
Expand Down

0 comments on commit 67bf8e1

Please sign in to comment.