Skip to content

Commit

Permalink
[KYUUBI #5737] [DOC] Correct JDBC URL demo in Flink docs
Browse files Browse the repository at this point in the history
# 🔍 Description
flink setting need additional prefix flink. to override settings
## Issue References 🔗

This pull request fixes #5737

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [x] Pull request title is okay.
- [x] No license issues.
- [x] Milestone correctly set?
- [ ] Test coverage is ok
- [x] Assignees are selected.
- [x] Minimum number of approvals
- [x] No changes are requested

**Be nice. Be informative.**

Closes #5745 from dik111/update-doc.

Closes #5737

27ac6c1 [yuwei zhan] Update AllKyuubiConfiguration about flink jdbc url
a1b1b2c [yuwei zhan] Update settings.md

Lead-authored-by: Yuwei Zhan <[email protected]>
Co-authored-by: yuwei zhan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
dik111 authored and pan3793 committed Nov 21, 2023
1 parent 9306e57 commit 931b502
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/configuration/settings.md
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ The below options in `kyuubi-defaults.conf` will set `parallelism.default: 2` an

### Via JDBC Connection URL

Setting them in the JDBC Connection URL supplies session-specific for each SQL engine. For example: ```jdbc:hive2://localhost:10009/default;#parallelism.default=2;taskmanager.memory.process.size=5g```
Setting them in the JDBC Connection URL supplies session-specific for each SQL engine. For example: ```jdbc:hive2://localhost:10009/default;#flink.parallelism.default=2;flink.taskmanager.memory.process.size=5g```

### Via SET Statements

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
"### Via JDBC Connection URL" +=
"""Setting them in the JDBC Connection URL supplies session-specific
| for each SQL engine. For example: ```jdbc:hive2://localhost:10009/default;
|#parallelism.default=2;taskmanager.memory.process.size=5g```
|#flink.parallelism.default=2;flink.taskmanager.memory.process.size=5g```
|""" +=
"### Via SET Statements" +=
"""Please refer to the Flink official online documentation for [SET Statements]
Expand Down

0 comments on commit 931b502

Please sign in to comment.