async stop

apache · Feb 4, 2024 · 992aefd · 992aefd
1 parent b39c9b3
commit 992aefd
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/...yuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala b/...yuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala
@@ -175,9 +175,12 @@ case class SparkSQLEngine(spark: SparkSession) extends Serverable("SparkSQLEngin
         val elapsedTime = System.currentTimeMillis() - getStartTime
         if (!shutdown.get && elapsedTime > maxLifetime) {
           if (deregistered.compareAndSet(false, true)) {
-            info(s"Spark engine has been running for more than $maxLifetime ms," +
-              s" deregistering from engine discovery space.")
-            frontendServices.flatMap(_.discoveryService).foreach(_.stop())
+            ThreadUtils.runInNewThread("engine-de-register") {
+              // for ETCD, the de-registering process might be blocked, so deregister it async
+              info(s"Spark engine has been running for more than $maxLifetime ms," +
+                s" deregistering from engine discovery space.")
+              frontendServices.flatMap(_.discoveryService).foreach(_.stop())
+            }
           }
 
           if (backendService.sessionManager.getOpenSessionCount <= 0) {