Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Cheng Pan <[email protected]>
  • Loading branch information
XorSum and pan3793 authored Feb 29, 2024
1 parent 0638ec9 commit 9b2df84
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ case class EnginePage(parent: EngineTab) extends WebUIPage("") {
("Start Time", true, None),
("Finish Time", true, None),
("Duration", true, None),
("Cpu Time", true, None),
("CPU Time", true, None),
("Total Statements", true, None))

headerStatRow(
Expand Down Expand Up @@ -486,7 +486,7 @@ private class StatementStatsPagedTable(
("Create Time", true, None),
("Finish Time", true, None),
("Duration", true, None),
("Cpu Time", true, None),
("CPU Time", true, None),
("Statement", true, None),
("State", true, None),
("Query Details", true, None),
Expand Down Expand Up @@ -596,7 +596,7 @@ private class SessionStatsTableDataSource(
case "Start Time" => Ordering.by(_.startTime)
case "Finish Time" => Ordering.by(_.endTime)
case "Duration" => Ordering.by(_.duration)
case "Cpu Time" => Ordering.by(_.sessionCpuTime)
case "CPU Time" => Ordering.by(_.sessionCpuTime)
case "Total Statements" => Ordering.by(_.totalOperations)
case unknownColumn => throw new IllegalArgumentException(s"Unknown column: $unknownColumn")
}
Expand Down Expand Up @@ -632,7 +632,7 @@ private class StatementStatsTableDataSource(
case "Create Time" => Ordering.by(_.createTime)
case "Finish Time" => Ordering.by(_.completeTime)
case "Duration" => Ordering.by(_.duration)
case "Cpu Time" => Ordering.by(_.operationCpuTime.getOrElse(0L))
case "CPU Time" => Ordering.by(_.operationCpuTime.getOrElse(0L))
case "Statement" => Ordering.by(_.statement)
case "State" => Ordering.by(_.state)
case "Query Details" => Ordering.by(_.executionId)
Expand Down

0 comments on commit 9b2df84

Please sign in to comment.