Skip to content

Commit

Permalink
[KYUUBI #5922] Enhance YARN app state judgment
Browse files Browse the repository at this point in the history
# 🔍 Description
## Issue References 🔗

This pull request aims to enhance the YARN app state judgment.

The combination of FINISHED and FAILED is valid, but Kyuubi now print ERROR logs

<img width="745" alt="image" src="https://github.com/apache/kyuubi/assets/26535726/6bb43f09-9c69-418f-85c7-15e2716226f8">

```
[ERROR] YarnApplicationOperation#94 - Unknown YARN state FINISHED for app application_1700805876733_11637 with final status FAILED.
```

## Describe Your Solution 🔧

The fix just suppresses the ERROR logs, does not change the behavior, because the previous implementation treats all invalid combinations as FAILED too.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [x] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [x] Pull request title is okay.
- [x] No license issues.
- [x] Milestone correctly set?
- [ ] Test coverage is ok
- [x] Assignees are selected.
- [x] Minimum number of approvals
- [x] No changes are requested

**Be nice. Be informative.**

Closes #5922 from pan3793/yarn-state.

Closes #5922

2ba30ce [Cheng Pan] Enhance YARN app state judgement

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
pan3793 committed Dec 26, 2023
1 parent 86bec4d commit c6177ab
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ object YarnApplicationOperation extends Logging {
ApplicationState.RUNNING
case (YarnApplicationState.FINISHED, FinalApplicationStatus.SUCCEEDED) =>
ApplicationState.FINISHED
case (YarnApplicationState.FAILED, FinalApplicationStatus.FAILED) =>
case (YarnApplicationState.FINISHED, FinalApplicationStatus.FAILED) |
(YarnApplicationState.FAILED, FinalApplicationStatus.FAILED) =>
ApplicationState.FAILED
case (YarnApplicationState.KILLED, FinalApplicationStatus.KILLED) =>
ApplicationState.KILLED
Expand Down

0 comments on commit c6177ab

Please sign in to comment.