[KYUUBI #5391] Close batch session after batch operation completion f…

…or idle timeout ### _Why are the changes needed?_ To add a limitation for batch session lifecycle. otherwise, the batch session might always alive. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No. Closes #5391 from turboFei/close_session_with_maxtimeout. Closes #5391 5639c7d [fwang12] session no op Authored-by: fwang12 <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
apache · Oct 10, 2023 · e1d213e · e1d213e
1 parent e33df9c
commit e1d213e
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSession.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSession.scala
@@ -61,9 +61,13 @@ class KyuubiBatchSession(
   override def createTime: Long = metadata.map(_.createTime).getOrElse(super.createTime)
 
   override def getNoOperationTime: Long = {
-    if (batchJobSubmissionOp != null && !OperationState.isTerminal(
-        batchJobSubmissionOp.getStatus.state)) {
-      0L
+    if (batchJobSubmissionOp != null) {
+      val batchStatus = batchJobSubmissionOp.getStatus
+      if (!OperationState.isTerminal(batchStatus.state)) {
+        0L
+      } else {
+        System.currentTimeMillis() - batchStatus.completed
+      }
     } else {
       super.getNoOperationTime
     }