[KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulysses-you
reviewed
Sep 28, 2022
...k-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/PlanOnlyStatement.scala
Show resolved
Hide resolved
...k-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/PlanOnlyStatement.scala
Outdated
Show resolved
Hide resolved
ulysses-you
approved these changes
Sep 28, 2022
yaooqinn
reviewed
Sep 28, 2022
iodone
force-pushed
the
kyuubi-3444
branch
2 times, most recently
from
f66202d to
74a2783
Compare
Codecov Report
@@ Coverage Diff @@
## master #3558 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 589 590 +1
Lines 33311 33346 +35
Branches 4399 4404 +5
======================================
- Misses 33311 33346 +35
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
iodone
force-pushed
the
kyuubi-3444
branch
2 times, most recently
from
df6d76d to
91bfa68
Compare
|
the github action seems get sick.. every commit need approve to run : ( |
iodone
force-pushed
the
kyuubi-3444
branch
6 times, most recently
from
04b8e24 to
af79aa7
Compare
ulysses-you
reviewed
Oct 13, 2022
.../kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/KyuubiSparkUtil.scala
Outdated
Show resolved
Hide resolved
iodone
force-pushed
the
kyuubi-3444
branch
2 times, most recently
from
5c58727 to
34e18f6
Compare
3 tasks
iodone
force-pushed
the
kyuubi-3444
branch
2 times, most recently
from
ca31fc4 to
faf3621
Compare
|
We can define a PlanOnlyStatement mode interface in Engine, and then implement it in the lineage plugin. |
|
cc @ulysses-you |
ulysses-you
approved these changes
Sep 1, 2023
|
thanks, merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3444
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request