[KYUUBI #5834] Add Grafana dashboard template #5147
Conversation
|
plz help review @pan3793 @zwangsheng . Thanks all.😄 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5147 +/- ##
=============================================
+ Coverage 0.00% 61.19% +61.19%
- Complexity 0 23 +23
=============================================
Files 566 622 +56
Lines 31601 36882 +5281
Branches 4120 5014 +894
=============================================
+ Hits 0 22570 +22570
+ Misses 31601 11872 -19729
- Partials 0 2440 +2440 ☔ View full report in Codecov by Sentry. |
|
Could you append a full screenshot to the desciption for demonstrating the dashboard? |
|
Added screenshots. Thanks. |
|
Yup. We can remove the threshold if it's not required. @zwangsheng |
|
plz review it @pan3793 |
grafana/Dockerfile
Outdated
| # under the grafana folder. | ||
| # 1. docker build --build-arg PROMETHEUS_URL_ARG="" -t grafana:kyuubi -f Dockerfile . | ||
| # Options: | ||
| # --build-arg the url to access promethues datasource |
There was a problem hiding this comment.
what's the value should be like? could you please add an example in the description?
grafana/Dockerfile
Outdated
| # limitations under the License. | ||
| # | ||
|
|
||
| # Usage: |
There was a problem hiding this comment.
please create a REAMDE.md in the same folder, and move this guidance to README.md
There was a problem hiding this comment.
appreciate it. I already provided REAMDE.md to guide users.
|
Currently, the default value of |
| ENV PROMETHEUS_URL=$PROMETHEUS_URL_ARG | ||
| COPY ./dashboard.yml /etc/grafana/provisioning/dashboards/ | ||
| COPY ./datasource.yml /etc/grafana/provisioning/datasources/ | ||
| COPY ./*.json /var/lib/grafana/dashboards/ |
There was a problem hiding this comment.
We should add empty line at end of file.
| editable: true | ||
| allowUiUpdates: true | ||
| options: | ||
| path: /var/lib/grafana/dashboards/ |
| access: proxy | ||
| url: ${PROMETHEUS_URL} | ||
| isDefault: true | ||
| editable: false |
pan3793
changed the title
|
@pan3793 plz help review it |
I'm OK with this, but it seems that we'd better to raise a discussion thread in dev |
The default metrics reporter has been set to Prometheus in #5344. |
|
Thank you @bowenliang123 |
|
hey folks, any blockers on this 🤔 ? |
It still needs some time to be reviewed. |
|
Hi, @zhaohehuhu some metrics do not include instance filtering, such as the expression in 'Thread Status'. When testing with Kyuubi version '1.9.1', metric names may depending on the Garbage Collector. For example, 'kyuubi_memory_usage_pools_PS_Eden_Space_used' may appear as 'kyuubi_memory_usage_pools_Eden_Space_used'. |
Thanks. I'll update it. |
Why are the changes needed?
would like to close #2526 so that users can visualize metric data in grafana dashboard once Kyuubi service exposes metrics to prometheus.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request