Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KYUUBI #5234] Upgrade Jetty version from 9.4.51.v20230217 to 9.4.52.v20230823 #5239

Closed
wants to merge 5 commits into from
Closed

[KYUUBI #5234] Upgrade Jetty version from 9.4.51.v20230217 to 9.4.52.v20230823 #5239

wants to merge 5 commits into from

Conversation

sidhant-nagpal
Copy link
Contributor

@sidhant-nagpal sidhant-nagpal commented Sep 2, 2023 •
edited
Loading

Fixes #5234

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023 •
edited
Loading

Codecov Report

Merging #5239 (f15af28) into master (593b582) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head f15af28 differs from pull request most recent head cbd4b49. Consider uploading reports for the commit cbd4b49 to get more accurate results

@@          Coverage Diff           @@
##           master   #5239   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         590     590           
  Lines       33344   33344           
  Branches     4403    4403           
======================================
  Misses      33344   33344

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cxzl25 cxzl25 changed the title Upgraded Jetty version from 9.4.51.v20230217 to 9.4.52.v20230823 [KYUUBI #5234] Upgraded Jetty version from 9.4.51.v20230217 to 9.4.52.v20230823 Sep 3, 2023
@pan3793
Copy link
Member

pan3793 commented Sep 4, 2023

@sidhant-nagpal thanks for your contribution, please follow the docs to upgrade the dependencyList

@sidhant-nagpal
Copy link
Contributor Author

@pan3793 Thanks for pointing to the docs, I changed jetty-* versions in dependencyList earlier but reverted later and made another push to the branch. weird, it is still saying "Dependency List Change Detected".
Checked locally, says no diff. Ran build/dependency.sh --replace also.

@pan3793
Copy link
Member

pan3793 commented Sep 4, 2023

The first commit looks good, please revert your last commit

@pan3793 pan3793 added this to the v1.8.0 milestone Sep 4, 2023
@sidhant-nagpal
Merge branch 'master' of https://github.com/sidhant-nagpal/kyuubi int…
608a510 
…o fix#5234/jetty-upgraded-from-9.4.51.v20230217-to-9.4.52.v20230823
@sidhant-nagpal
Merge branch 'master' of https://github.com/sidhant-nagpal/kyuubi int…
cbd4b49 
…o fix#5234/jetty-upgraded-from-9.4.51.v20230217-to-9.4.52.v20230823
@pan3793 pan3793 changed the title [KYUUBI #5234] Upgraded Jetty version from 9.4.51.v20230217 to 9.4.52.v20230823 [KYUUBI #5234] Upgrade Jetty version from 9.4.51.v20230217 to 9.4.52.v20230823 Sep 4, 2023
@pan3793
Copy link
Member

pan3793 commented Sep 4, 2023

Seems there are some issues with GitHub actions, the change should be safe, merging to master/1.8

@pan3793 pan3793 closed this in 5abc262 Sep 4, 2023
pan3793 pushed a commit that referenced this pull request Sep 4, 2023
@sidhant-nagpal @pan3793
[KYUUBI #5234] Upgrade Jetty version from 9.4.51.v20230217 to 9.4.52.…
97dfb43 
…v20230823

Fixes #5234

Closes #5239 from sidhant-nagpal/fix#5234/jetty-upgraded-from-9.4.51.v20230217-to-9.4.52.v20230823.

Closes #5234

cbd4b49 [Sidhant Nagpal] Merge branch 'master' of https://github.com/sidhant-nagpal/kyuubi into fix#5234/jetty-upgraded-from-9.4.51.v20230217-to-9.4.52.v20230823
608a510 [Sidhant Nagpal] Merge branch 'master' of https://github.com/sidhant-nagpal/kyuubi into fix#5234/jetty-upgraded-from-9.4.51.v20230217-to-9.4.52.v20230823
d2ac35e [Sidhant Nagpal] Revert "#5234 Upgrade Jetty from 9.4.51.v20230217 to 9.4.52.v20230823"
f15af28 [Sidhant Nagpal] #5234 Upgrade Jetty from 9.4.51.v20230217 to 9.4.52.v20230823
2498302 [Sidhant Nagpal] #5234 Upgrade Jetty from 9.4.51.v20230217 to 9.4.52.v20230823

Authored-by: Sidhant Nagpal <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 5abc262)
Signed-off-by: Cheng Pan <[email protected]>
@sidhant-nagpal
Copy link
Contributor Author

sidhant-nagpal commented Sep 4, 2023 •
edited
Loading

@pan3793 cool : )
Thanks !

@sidhant-nagpal sidhant-nagpal deleted the fix#5234/jetty-upgraded-from-9.4.51.v20230217-to-9.4.52.v20230823 branch September 4, 2023 14:10
@sidhant-nagpal sidhant-nagpal restored the fix#5234/jetty-upgraded-from-9.4.51.v20230217-to-9.4.52.v20230823 branch September 4, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan3793 pan3793 pan3793 approved these changes

Assignees

@sidhant-nagpal sidhant-nagpal

Labels
kind:build
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Upgrade Jetty from 9.4.51.v20230217 to 9.4.52.v20230823
3 participants
@sidhant-nagpal @codecov-commenter @pan3793