Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTHZ] Drop Hive and Iceberg tables with PURGE option in tests #5323

Closed
wants to merge 1 commit into from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Sep 25, 2023

Why are the changes needed?

  • DROP TABLE for Iceberg tables only removes the table from catalog by default, which may contaminates other tests with same table
  • Enable PURGE option for dropping Iceberg and Hive table
    • Iceberg Spark DDL DROP TABLE ... PURGE
    • To drop the table from the catalog and delete the table’s contents

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

@bowenliang123 bowenliang123 changed the title [TEST] Drop iceberg table with PURGE option [TEST] Drop Iceberg table with PURGE option Sep 25, 2023
@bowenliang123 bowenliang123 changed the title [TEST] Drop Iceberg table with PURGE option [TEST] Drop Hive and Iceberg table with PURGE option Sep 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #5323 (ce4188d) into master (fd69c6e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5323   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         588     588           
  Lines       33423   33423           
  Branches     4391    4391           
======================================
  Misses      33423   33423           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bowenliang123 bowenliang123 changed the title [TEST] Drop Hive and Iceberg table with PURGE option [AUTHZ] Drop Hive and Iceberg table with PURGE option when cleanup tables in testing Oct 11, 2023
@bowenliang123 bowenliang123 force-pushed the iceberg-purge branch 3 times, most recently from 2b9e122 to 3c4196f Compare October 12, 2023 02:56
@bowenliang123 bowenliang123 changed the title [AUTHZ] Drop Hive and Iceberg table with PURGE option when cleanup tables in testing [AUTHZ] Drop Hive and Iceberg tables with PURGE option in tests Oct 12, 2023
@bowenliang123 bowenliang123 marked this pull request as ready for review October 12, 2023 05:38
@bowenliang123 bowenliang123 requested review from yaooqinn, pan3793 and wForget and removed request for yaooqinn October 12, 2023 13:50
Copy link
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bowenliang123 bowenliang123 self-assigned this Oct 13, 2023
@bowenliang123 bowenliang123 added this to the v1.8.0 milestone Oct 13, 2023
@bowenliang123 bowenliang123 modified the milestones: v1.8.0, v1.9.0 Oct 13, 2023
@bowenliang123 bowenliang123 deleted the iceberg-purge branch October 13, 2023 06:48
@bowenliang123
Copy link
Contributor Author

Thanks, merged to master (1.9.0) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants