Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #5358] Bump iceberg 1.4.0 #5358

Closed
wants to merge 2 commits into from

Conversation

wForget
Copy link
Member

@wForget wForget commented Oct 8, 2023

Why are the changes needed?

https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.4.0

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

No

@wForget wForget changed the title Bump iceberg 1.4.0 [KYUUBI #5358] Bump iceberg 1.4.0 Oct 8, 2023
@@ -2190,6 +2190,7 @@
<spark.version>3.1.3</spark.version>
<spark.binary.version>3.1</spark.binary.version>
<delta.version>1.0.1</delta.version>
<iceberg.version>1.3.1</iceberg.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iceberg 1.4.0 removes support for spark 3.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's document it in the comment

"Iceberg removed the support for Spark 3.1 in apache/iceberg#xxxx since 1.4.0"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iceberg removed the support for Spark 3.1 in apache/iceberg#8661 since 1.4.0

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

Merging #5358 (e03d8d6) into master (2690d6d) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5358   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         590     590           
  Lines       33493   33493           
  Branches     4424    4424           
======================================
  Misses      33493   33493           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wForget wForget self-assigned this Oct 8, 2023
@wForget wForget added this to the v1.8.0 milestone Oct 8, 2023
@pan3793 pan3793 closed this in 34bf47c Oct 8, 2023
@pan3793
Copy link
Member

pan3793 commented Oct 8, 2023

Merged to master/1.8

pan3793 pushed a commit that referenced this pull request Oct 8, 2023
### _Why are the changes needed?_

https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.4.0

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No

Closes #5358 from wForget/bump_iceberg_1_4.

Closes #5358

e03d8d6 [wforget] comment
db0b6b9 [wforget] Bump iceberg 1.4.0

Authored-by: wforget <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 34bf47c)
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants