[DOCS] Update config docs regeneratoin hints in developer guide #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
approved these changes
Oct 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #5409 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33423 33423
Branches 4391 4391
======================================
Misses 33423 33423 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bowenliang123
added a commit
that referenced
this pull request
Oct 12, 2023
…per guide ### _Why are the changes needed?_ - Update the regeneration hits for `setting.md` in `develop.md`, as the config doc`settings.md` is checked and able to regenearted by `dev/gen/gen_all_config_docs.sh` script. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No. Closes #5409 from bowenliang123/regen-settings. Closes #5409 985f39e [Bowen Liang] update docs Authored-by: Bowen Liang <[email protected]> Signed-off-by: Bowen Liang <[email protected]> (cherry picked from commit 74e52f6) Signed-off-by: Bowen Liang <[email protected]>
|
Thanks, merged to master(1.9.0) and branch-1.8 (1.8.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
setting.mdindevelop.md, as the config docsettings.mdis checked and able to regenearted bydev/gen/gen_all_config_docs.shscript.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No.