[KYUUBI #5446][AUTHZ] Support Create/Drop/Show/Reresh index command for Hudi #5448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...yuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/HudiCommands.scala
Outdated
Show resolved
Hide resolved
...yuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/HudiCommands.scala
Outdated
Show resolved
Hide resolved
pan3793
changed the title
AngersZhuuuu
commented
Oct 18, 2023
...scala/org/apache/kyuubi/plugin/spark/authz/ranger/HudiCatalogRangerSparkExtensionSuite.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #5448 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33480 33466 -14
Branches 4405 4401 -4
======================================
+ Misses 33480 33466 -14 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bowenliang123
changed the title
yaooqinn
reviewed
Oct 19, 2023
...scala/org/apache/kyuubi/plugin/spark/authz/ranger/HudiCatalogRangerSparkExtensionSuite.scala
Show resolved
Hide resolved
AngersZhuuuu
commented
Oct 24, 2023
...uubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/AccessType.scala
Show resolved
Hide resolved
AngersZhuuuu
commented
Oct 24, 2023
...-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/AccessResource.scala
Show resolved
Hide resolved
AngersZhuuuu
commented
Oct 24, 2023
...park/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ObjectType.scala
Outdated
Show resolved
Hide resolved
|
Ping @yaooqinn Could you take a view again? |
AngersZhuuuu
commented
Oct 24, 2023
...k/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/OperationType.scala
Show resolved
Hide resolved
yaooqinn
reviewed
Oct 25, 2023
extensions/spark/kyuubi-spark-authz/src/main/resources/table_command_spec.json
Outdated
Show resolved
Hide resolved
yaooqinn
approved these changes
Oct 25, 2023
yaooqinn
approved these changes
Oct 25, 2023
|
This is an excellent feature to have! Thanks @AngersZhuuuu merged to master |
davidyuan1223
pushed a commit
to davidyuan1223/kyuubi
that referenced
this pull request
Oct 26, 2023
…mand for Hudi ### _Why are the changes needed?_ To close apache#5446. Kyuubi authz support Create/Drop/Show/Reresh index based command IndexBasedCommand SQL grammer is in https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark/src/main/antlr4/org/apache/hudi/spark/sql/parser/HoodieSqlCommon.g4 Below command under https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/IndexCommands.scala - CreateIndexCommand - DropIndexCommand - RefreshIndexCommand - ShowIndexesCommand ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No Closes apache#5448 from AngersZhuuuu/KYUUBI-5446. Closes apache#5446 1be0561 [Angerszhuuuu] Update ObjectType.scala c4ae073 [Angerszhuuuu] follow comment ed1544e [Angerszhuuuu] Update 214bb86 [Angerszhuuuu] Update OperationType.scala 97cb0f8 [Angerszhuuuu] Update PrivilegeObject.scala bc65abd [Angerszhuuuu] update 0e6f6df [Angerszhuuuu] Update 4019f45 [Angerszhuuuu] update dc9188d [Angerszhuuuu] update f9a398c [Angerszhuuuu] Merge branch 'master' into KYUUBI-5446 52f67e9 [Angerszhuuuu] update bed945e [Angerszhuuuu] Merge branch 'master' into KYUUBI-5446 f174ef2 [Angerszhuuuu] Update table_command_spec.json 4764531 [Angerszhuuuu] Merge branch 'master' into KYUUBI-5446 a78425b [Angerszhuuuu] Update HudiCommands.scala 81881db [Angerszhuuuu] Update HudiCommands.scala 544a443 [Angerszhuuuu] Update HudiCommands.scala aed91cd [Angerszhuuuu] Merge branch 'master' into KYUUBI-5446 9632886 [Angerszhuuuu] Update HudiCatalogRangerSparkExtensionSuite.scala c404fd7 [Angerszhuuuu] Update HudiCatalogRangerSparkExtensionSuite.scala e70c8f1 [Angerszhuuuu] Update HudiCatalogRangerSparkExtensionSuite.scala fefb021 [Angerszhuuuu] Update table_command_spec.json ab8b96d [Angerszhuuuu] Merge branch 'master' into KYUUBI-5446 fcb3d45 [Angerszhuuuu] Update HudiCatalogRangerSparkExtensionSuite.scala b1657d9 [Angerszhuuuu] follow comment 0222e02 [Angerszhuuuu] [KYUUBI-5446][AUTHZ] Support Create/Drop/Show/Reresh index command Authored-by: Angerszhuuuu <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To close #5446. Kyuubi authz support Create/Drop/Show/Reresh index based command
IndexBasedCommand SQL grammer is in https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark/src/main/antlr4/org/apache/hudi/spark/sql/parser/HoodieSqlCommon.g4
Below command under https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/IndexCommands.scala
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No