Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTHZ] Support create table command for Paimon #5462

Closed

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Oct 18, 2023

Why are the changes needed?

Apache Paimon is an incubating Apache project of data lake platform for high-speed data ingestion, changelog tracking and efficient real-time analytics.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

No.

@bowenliang123 bowenliang123 marked this pull request as draft October 18, 2023 09:32
@bowenliang123 bowenliang123 changed the title [AUTHZ] Support create table for Paimon [AUTHZ] Support create table command for Paimon Oct 18, 2023
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bowenliang123 bowenliang123 marked this pull request as ready for review October 18, 2023 10:03
@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label Oct 18, 2023
@bowenliang123 bowenliang123 marked this pull request as draft October 18, 2023 12:45
@bowenliang123 bowenliang123 marked this pull request as ready for review October 18, 2023 14:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #5462 (8393f6e) into master (8d2c8d1) will not change coverage.
Report is 6 commits behind head on master.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5462   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         588     588           
  Lines       33454   33466   +12     
  Branches     4401    4401           
======================================
- Misses      33454   33466   +12     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bowenliang123 bowenliang123 self-assigned this Oct 19, 2023
@bowenliang123 bowenliang123 added this to the v1.9.0 milestone Oct 19, 2023
@bowenliang123
Copy link
Contributor Author

Thanks, merged to master (1.9.0) .

@bowenliang123 bowenliang123 deleted the authz-paimon-createtable branch October 19, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:build kind:infra license, community building, project builds, asf infra related, etc. module:authz module:extensions module:spark
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants