Donate PyHive to Apache Kyuubi #5686
Conversation
|
Many thanks, @bkyryliuk. As we discussed, let's hold on a while to wait for SGA to get approved by ASF. |
|
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag! Thank you for using Kyuubi! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5686 +/- ##
============================================
+ Coverage 61.49% 63.88% +2.38%
Complexity 23 23
============================================
Files 604 624 +20
Lines 35689 42214 +6525
Branches 4884 6032 +1148
============================================
+ Hits 21948 26967 +5019
- Misses 11375 12698 +1323
- Partials 2366 2549 +183 ☔ View full report in Codecov by Sentry. |
pan3793
changed the title
|
SGA has been received, and I have sent the IP CLEARANCE to the Incubator mailing list - https://lists.apache.org/thread/8nlbpo2ckwshsn9rvnstmzpgns2tn4fl We can start the code merging process now |
| ================================ | ||
| Project is currently unsupported | ||
| ================================ | ||
|
|
||
|
|
||
|
|
||
|
|
||
| .. image:: https://travis-ci.org/dropbox/PyHive.svg?branch=master | ||
| :target: https://travis-ci.org/dropbox/PyHive | ||
| .. image:: https://img.shields.io/codecov/c/github/dropbox/PyHive.svg | ||
|
|
There was a problem hiding this comment.
Please remove this part
| ================================ | |
| Project is currently unsupported | |
| ================================ | |
| .. image:: https://travis-ci.org/dropbox/PyHive.svg?branch=master | |
| :target: https://travis-ci.org/dropbox/PyHive | |
| .. image:: https://img.shields.io/codecov/c/github/dropbox/PyHive.svg |
|
|
||
| Contributing | ||
| ============ | ||
| - Please fill out the Dropbox Contributor License Agreement at https://opensource.dropbox.com/cla/ and note this in your pull request. |
There was a problem hiding this comment.
Please remove this line
| - Please fill out the Dropbox Contributor License Agreement at https://opensource.dropbox.com/cla/ and note this in your pull request. |
| url='https://github.com/dropbox/PyHive', | ||
| author="Jing Wang", | ||
| author_email="[email protected]", |
There was a problem hiding this comment.
| url='https://github.com/dropbox/PyHive', | |
| author="Jing Wang", | |
| author_email="[email protected]", | |
| url='https://github.com/apache/kyuubi/python', | |
| author="Apache Kyuubi Developers", | |
| author_email="[email protected]", |
|
@bkyryliuk would you mind making the following changes? Then we can merge this patch.
Apache Kyuubi
Copyright 2021-2024 The Apache Software Foundation.
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
+ (This is an example, please tune the words by yourself)
+ Portions of this software were developed at Dropbox, Inc.
... |
|
kindly ping @bkyryliuk, appreciate it if you could take minutes to tune this commit |
|
To unblock the ongoing development, I'm going to merge this PR as-is. |
|
Merged to master |
# 🔍 Description This is the follow-up of #5686, renaming `./pyhive` to `./python`, and also adding `**/python/*` to RAT exclusion list temporarily. "PyHive" may not be a suitable name after being part of Apache Kyuubi, let's use a generic dir name `python`, and discuss the official name later(we probably keep the code at `./python` eventually). ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Recover RAT checked. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6279 from pan3793/pyhive-1. Closes #5686 42d338e [Cheng Pan] [KYUUBI #5686][FOLLOWUP] Rename pyhive to python Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
|
@pan3793 apologies for the delay, I had no free time until recently. Is there anything else needed or are you unblocked ? |
|
@bkyryliuk thanks for the reply, you may want to update the NOTICE as I mentioned here. Also would be good to update the PyHive README to mention the donation. Now, we are working on setup the CI #6281, and the next step is to finish the first PyPi release. We are likely to create a new project(I'm going to open a discussion on the mailing list) instead of an existing PyHive. So the following steps are optional
|
This pr: moves https://github.com/dropbox/PyHive to the pyhive folder in apache kyuubi project at d4ae481675ac5588ba9101596fa26f22ef0e77c4 commit
and changes the license text to the standard Apache License Version 2.0.