Allow configuring kyuubi.engine.type
in short name
#5773
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
Currently, the value candidates of
kyuubi.engine.type
areSPARK_SQL
,FLINK_SQL
,TRINO
,HIVE_SQL
,JDBC
,CHAT
, which are inconsistent.Describe Your Solution 🔧
We may want to unify them by removing the tailing
_SQL
in the future, before doing that, let's support such values as aliases first.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
configuring
kyuubi.engine.type
asSPARK
orFLINK
orHIVE
is invalid, must beSPARK_SQL
orFLINK_SQL
orHIVE_SQL
.Behavior With This Pull Request 🎉
all of
SPARK
,SPARK_SQL
,FLINK
,FLINK_SQL
,HIVE
,HIVE_SQL
is validRelated Unit Tests
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.