-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #5396] SBT build support #5775
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5775 +/- ##
============================================
- Coverage 61.37% 61.37% -0.01%
Complexity 23 23
============================================
Files 607 607
Lines 35927 35944 +17
Branches 4931 4936 +5
============================================
+ Hits 22051 22061 +10
+ Misses 11492 11490 -2
- Partials 2384 2393 +9 ☔ View full report in Codecov by Sentry. |
What do you think about this code change? Please give me some advice, i will fix them, then add the doc about sbt. |
In addition to this, where sbt ci should be added to github workflow, and sbt may not support all projects at this time |
@pan3793 @cfmcgrady @bowenliang123 Hello, I'm sorry, I don't think I can complete this issue. Although I have set up a basic environment, during local debugging, I always fail when I test these projects. After searching a lot of solutions, I still can't solve these problems, so I think this issue may be more suitable for people who are proficient in SBT to complete. |
@davidyuan1223 this may be challenging for developers who are not familiar with SBT, anyway, thanks for your effort |
This's quite challenging to bring a complicated multi-module Maven project into sbt native project. It requires experience, insight and fine tuning in both tools and related counterpart plugins, even with the help of sbt maven migration kits. |
🔍 Description
Issue References 🔗
This pull request fixes #5396
Describe Your Solution 🔧
This pull request used to support sbt build.
The load projects are base projects, if we want load another projects, we need use
-P${profile}
, for examples we use./build/sbt -Pspark-3.3 projects
, the projects will contains[info] kyuubi-extension-spark-3-3
In the end, this pull request is a basic support for sbt, some speical dependency in project, we need change the Build.scala to support.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.