Include hive-service-rpc in Hive engine jar
#5777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
changed the title
hive-service-rpc in Hive engine jar
pan3793
approved these changes
Nov 27, 2023
|
Though it may introduce class conflict issues, but such a workaround definitely makes Hive engine work well with Hive 2.1, I think we can merge it and explore long-term solutions in the future |
pan3793
pushed a commit
that referenced
this pull request
Nov 27, 2023
# 🔍 Description ## Issue References 🔗 Exception was thrown when execute SQL on HiveSQLEngine when HIVE_HOME set to Hive 2.1.1-cdh6.3.2.  ## Describe Your Solution 🔧 hive-service-rpc-2.1.1-cdh6.3.2.jar is not compatible with Kyuubi Server's hive-service-rpc. We should use Kyuubi Server's hive-service-rpc at HiveSQLEngine side. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Exception was thrown  #### Behavior With This Pull Request 🎉 SQL execute successfully <img width="1545" alt="image" src="https://github.com/apache/kyuubi/assets/88070094/8bb7cfa0-0af0-42cf-acf5-40cff39efd1f"> #### Related Unit Tests --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [x] Pull request title is okay. - [x] No license issues. - [x] Milestone correctly set? - [ ] Test coverage is ok - [x] Assignees are selected. - [x] Minimum number of approvals - [x] No changes are requested **Be nice. Be informative.** Closes #5777 from zhouyifan279/hive-sql-engine. Closes #5777 c55903a [zhouyifan279] Include org.apache.hive:hive-service-rpc in HiveSQLEngine jar Authored-by: zhouyifan279 <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 65ba3b1) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
Exception was thrown when execute SQL on HiveSQLEngine when HIVE_HOME set to Hive 2.1.1-cdh6.3.2.
Describe Your Solution 🔧
hive-service-rpc-2.1.1-cdh6.3.2.jar is not compatible with Kyuubi Server's hive-service-rpc.
We should use Kyuubi Server's hive-service-rpc at HiveSQLEngine side.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Exception was thrown
Behavior With This Pull Request 🎉
SQL execute successfully
Related Unit Tests
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.