[KYUUBI #5797][FOLLOWUP] Desc engine command support show engine registered attributes #5948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e registered attributes
beryllw
commented
Jan 5, 2024
kyuubi-server/src/main/scala/org/apache/kyuubi/sql/plan/command/DescribeEngine.scala
Outdated
Show resolved
Hide resolved
|
|
cxzl25
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5948 +/- ##
============================================
- Coverage 61.29% 61.08% -0.22%
Complexity 23 23
============================================
Files 622 622
Lines 36882 37052 +170
Branches 5014 5026 +12
============================================
+ Hits 22607 22633 +26
- Misses 11847 11969 +122
- Partials 2428 2450 +22 ☔ View full report in Codecov by Sentry. |
turboFei
reviewed
Jan 10, 2024
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
Outdated
Show resolved
Hide resolved
turboFei
reviewed
Jan 10, 2024
added 2 commits
January 16, 2024 18:08
turboFei
reviewed
Jan 16, 2024
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
Outdated
Show resolved
Hide resolved
turboFei
reviewed
Jan 18, 2024
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala
Outdated
Show resolved
Hide resolved
turboFei
approved these changes
Jan 18, 2024
|
thanks @Kwafoor |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Feb 5, 2024
…e registered attributes # 🔍 Description desc engine command support show engine registered attributes. ## Issue References 🔗 This pull request fixes apache#5797 ## Describe Your Solution 🔧 apache#5931 (comment) ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5948 from Kwafoor/kyuubi_5797_desc_engine_follow. Closes apache#5797 da89099 [wangjunbo] fix code 085ffc5 [wangjunbo] fix code d58e8ec [wangjunbo] delete empty lines cca773a [wangjunbo] fix code 9fcc2c6 [wangjunbo] delete ENGINE_NAMESPACE column 9dfb2f5 [wangjunbo] [KYUUBI apache#5797][FOLLOWUP] desc engine command support show engine registered attributes Authored-by: wangjunbo <[email protected]> Signed-off-by: Fei Wang <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…e registered attributes # 🔍 Description desc engine command support show engine registered attributes. ## Issue References 🔗 This pull request fixes apache#5797 ## Describe Your Solution 🔧 apache#5931 (comment) ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5948 from Kwafoor/kyuubi_5797_desc_engine_follow. Closes apache#5797 da89099 [wangjunbo] fix code 085ffc5 [wangjunbo] fix code d58e8ec [wangjunbo] delete empty lines cca773a [wangjunbo] fix code 9fcc2c6 [wangjunbo] delete ENGINE_NAMESPACE column 9dfb2f5 [wangjunbo] [KYUUBI apache#5797][FOLLOWUP] desc engine command support show engine registered attributes Authored-by: wangjunbo <[email protected]> Signed-off-by: Fei Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
desc engine command support show engine registered attributes.
Issue References 🔗
This pull request fixes #5797
Describe Your Solution 🔧
#5931 (comment)
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.