[AUTHZ] Supports check hoodie procedures show_commits resource privileges #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5965 +/- ##
============================================
- Coverage 61.23% 61.17% -0.07%
Complexity 23 23
============================================
Files 622 622
Lines 36884 36887 +3
Branches 5014 5014
============================================
- Hits 22586 22565 -21
- Misses 11857 11879 +22
- Partials 2441 2443 +2 ☔ View full report in Codecov by Sentry. |
cxzl25
approved these changes
Jan 14, 2024
|
thanks, merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…mmits resource privileges # 🔍 Description ## Issue References 🔗 This pull request aims to make AuthZ supports check [hoodie procedures show_commits](https://hudi.apache.org/docs/procedures#show_commits) resource privileges ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ `CALL show_commits` passes permission checks whether they have permission or not #### Behavior With This Pull Request 🎉 `CALL show_commits` will not pass without permission #### Related Unit Tests New test added, extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/HudiCatalogRangerSparkExtensionSuite.scala#ShowCommitsProcedure --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5965 from Yikf/hudi-showcommits. Closes apache#5965 4e609b0 [yikaifei] Supports check hoodie procedures show_commits resource privileges Authored-by: yikaifei <[email protected]> Signed-off-by: yikaifei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request aims to make AuthZ supports check hoodie procedures show_commits resource privileges
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
CALL show_commitspasses permission checks whether they have permission or notBehavior With This Pull Request 🎉
CALL show_commitswill not pass without permissionRelated Unit Tests
New test added, extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/HudiCatalogRangerSparkExtensionSuite.scala#ShowCommitsProcedure
Checklist 📝
Be nice. Be informative.