[KYUUBI #5966] Error occurs on clicking on the Spark UI Kyuubi Query Engine tab #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Jan 12, 2024
| val revision: String = props.getProperty("revision", unknown) | ||
| val revisionTime: String = props.getProperty("revision_time", unknown) | ||
| val branch: String = Option(props.getProperty("branch", unknown)) | ||
| .filterNot(_.isEmpty).getOrElse(unknown) |
There was a problem hiding this comment.
let extract a method and guard all properties
There was a problem hiding this comment.
@pan3793 good idea,i have updated, please check.
…ring index out of range: 7
Emor-nj
force-pushed
the
KyuubiQueryEngineTab
branch
from
3bcd851 to
213493a
Compare
pan3793
reviewed
Jan 12, 2024
Comment on lines
77
to
79
| private def getProperty(props: Properties, key: String, defaultValue: String): String = { | ||
| Option(props.getProperty(key, defaultValue)).filterNot(_.isEmpty).getOrElse(defaultValue) | ||
| } |
There was a problem hiding this comment.
we don't need to make it generic, move it to BuildInfo body and simply write as
Suggested change
| private def getProperty(props: Properties, key: String, defaultValue: String): String = { | |
| Option(props.getProperty(key, defaultValue)).filterNot(_.isEmpty).getOrElse(defaultValue) | |
| } | |
| private def getProperty(key: String, defaultValue: String = unknown): String = { | |
| Option(props.getProperty(key, defaultValue)).filterNot(_.isEmpty).getOrElse(defaultValue) | |
| } |
There was a problem hiding this comment.
I agree, thank you.
…ring index out of range: 7
pan3793
reviewed
Jan 12, 2024
pan3793
reviewed
Jan 12, 2024
pan3793
approved these changes
Jan 12, 2024
pan3793
changed the title
pan3793
added a commit
that referenced
this pull request
Jan 12, 2024
…Engine tab # 🔍 Description ## Issue References 🔗 This pull request fixes #5966 Fix Kyuubi Query Engine tab error:StringIndexOutOfBoundsException: String index out of range: 7 ## Describe Your Solution 🔧 When the variables branch, revision, revisionTime, repoUrl are empty strings ("")，assign them the default value "\<unknown\>". ## Types of changes :bookmark: - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request :coffin: #### Behavior With This Pull Request :tada: #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #5967 from Emor-nj/KyuubiQueryEngineTab. Closes #5966 0cee947 [Cheng Pan] Update kyuubi-common/src/main/scala/org/apache/kyuubi/package.scala 5d8c030 [Cheng Pan] Update kyuubi-common/src/main/scala/org/apache/kyuubi/package.scala 733a9af [Emor-nj] fix Kyuubi Query Engine tab error:StringIndexOutOfBoundsException: String index out of range: 7 213493a [Emor-nj] fix Kyuubi Query Engine tab error:StringIndexOutOfBoundsException: String index out of range: 7 Lead-authored-by: Cheng Pan <[email protected]> Co-authored-by: Emor-nj <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 57d531d) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.8 |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…Query Engine tab # 🔍 Description ## Issue References 🔗 This pull request fixes apache#5966 Fix Kyuubi Query Engine tab error:StringIndexOutOfBoundsException: String index out of range: 7 ## Describe Your Solution 🔧 When the variables branch, revision, revisionTime, repoUrl are empty strings ("")，assign them the default value "\<unknown\>". ## Types of changes :bookmark: - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request :coffin: #### Behavior With This Pull Request :tada: #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5967 from Emor-nj/KyuubiQueryEngineTab. Closes apache#5966 0cee947 [Cheng Pan] Update kyuubi-common/src/main/scala/org/apache/kyuubi/package.scala 5d8c030 [Cheng Pan] Update kyuubi-common/src/main/scala/org/apache/kyuubi/package.scala 733a9af [Emor-nj] fix Kyuubi Query Engine tab error:StringIndexOutOfBoundsException: String index out of range: 7 213493a [Emor-nj] fix Kyuubi Query Engine tab error:StringIndexOutOfBoundsException: String index out of range: 7 Lead-authored-by: Cheng Pan <[email protected]> Co-authored-by: Emor-nj <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #5966
Fix Kyuubi Query Engine tab error:StringIndexOutOfBoundsException: String index out of range: 7
Describe Your Solution 🔧
When the variables branch, revision, revisionTime, repoUrl are empty strings ("")，assign them the default value "<unknown>".
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.