[KYUUBI #5968] Support set authentication user for Trino engine #5970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5970 +/- ##
============================================
- Coverage 61.14% 61.12% -0.03%
Complexity 23 23
============================================
Files 622 622
Lines 37059 37063 +4
Branches 5027 5027
============================================
- Hits 22660 22654 -6
- Misses 11958 11966 +8
- Partials 2441 2443 +2 ☔ View full report in Codecov by Sentry. |
cxzl25
approved these changes
Jan 14, 2024
pan3793
reviewed
Jan 15, 2024
| @@ -141,7 +144,7 @@ class TrinoSessionImpl( | |||
| require( | |||
| serverScheme.equalsIgnoreCase("https"), | |||
| "Trino engine using username/password requires HTTPS to be enabled") | |||
| builder.addInterceptor(OkHttpUtil.basicAuth(username, password)) | |||
| builder.addInterceptor(OkHttpUtil.basicAuth(trinoUser, password)) | |||
There was a problem hiding this comment.
The ClientSession still uses username(session user), will this cause issues?
There was a problem hiding this comment.
The ClientSession still uses
username(session user), will this cause issues?
It only used for http verification, will have no other impact.
There was a problem hiding this comment.
as trinoUser is only used for auth, move the definition to here, and rename variable to user
pan3793
reviewed
Jan 19, 2024
| @@ -57,6 +57,9 @@ class TrinoSessionImpl( | |||
| private val username: String = sessionConf | |||
lsm1
force-pushed
the
branch-kyuubi-5968
branch
from
1c0bccf to
580eb45
Compare
pan3793
approved these changes
Jan 19, 2024
|
Thanks, merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Feb 5, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#5968 ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5970 from lsm1/branch-kyuubi-5968. Closes apache#5968 580eb45 [senmiaoliu] fix style a36380c [senmiaoliu] add auth user conf for trino engine Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#5968 ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5970 from lsm1/branch-kyuubi-5968. Closes apache#5968 580eb45 [senmiaoliu] fix style a36380c [senmiaoliu] add auth user conf for trino engine Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #5968
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.