Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump trino-client 411 #5975

Closed
wants to merge 5 commits into from
Closed

Bump trino-client 411 #5975

wants to merge 5 commits into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Jan 15, 2024

🔍 Description

Issue References 🔗

This is a regular dependency upgrading,

Describe Your Solution 🔧

Upgrade trino-client from 363 to 411. 411 is the latest version which uses okhttp 3.x, hence it does not have kotlin runtime dependencies.

This PR also updates the docs, especially the Trino cluster version requirement.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Pass GA.


Checklist 📝

Be nice. Be informative.

@github-actions github-actions bot added kind:infra license, community building, project builds, asf infra related, etc. module:spark labels Jan 15, 2024
@pan3793 pan3793 requested review from iodone and cxzl25 January 15, 2024 09:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9401a4) 61.17% compared to head (81d23c6) 61.16%.
Report is 3 commits behind head on master.

❗ Current head 81d23c6 differs from pull request most recent head 2b57df3. Consider uploading reports for the commit 2b57df3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5975      +/-   ##
============================================
- Coverage     61.17%   61.16%   -0.02%     
  Complexity       23       23              
============================================
  Files           622      622              
  Lines         36903    36897       -6     
  Branches       5017     5016       -1     
============================================
- Hits          22577    22568       -9     
- Misses        11885    11890       +5     
+ Partials       2441     2439       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 self-assigned this Jan 15, 2024
@pan3793 pan3793 added this to the v1.9.0 milestone Jan 15, 2024
@pan3793 pan3793 closed this in 87ed400 Jan 15, 2024
@pan3793
Copy link
Member Author

pan3793 commented Jan 15, 2024

Merged to master

pan3793 added a commit to pan3793/kyuubi that referenced this pull request Jan 15, 2024
pan3793 added a commit that referenced this pull request Jan 15, 2024
# 🔍 Description
## Issue References 🔗

This pull request fixes the UT

## Describe Your Solution 🔧

Trino 411 adds now data types, the UT should be updated accordingly.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

And pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #5979 from pan3793/5975-followup.

Closes #5975

832a482 [Cheng Pan] [KYUUBI #5975][FOLLOWUP][TEST] Fix trino - get type info

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Feb 5, 2024
# 🔍 Description
## Issue References 🔗

This is a regular dependency upgrading,

## Describe Your Solution 🔧

Upgrade `trino-client` from 363 to 411. 411 is the latest version which uses okhttp 3.x, hence it does not have kotlin runtime dependencies.

This PR also updates the docs, especially the Trino cluster version requirement.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5975 from pan3793/trino-411.

Closes apache#5975

2b57df3 [Cheng Pan] fix
c498a5b [Cheng Pan] fix
21948ca [Cheng Pan] Fix compile
e4f1397 [Cheng Pan] license
66583ca [Cheng Pan] Bump trino-client 411

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Feb 5, 2024
# 🔍 Description
## Issue References 🔗

This pull request fixes the UT

## Describe Your Solution 🔧

Trino 411 adds now data types, the UT should be updated accordingly.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

And pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5979 from pan3793/5975-followup.

Closes apache#5975

832a482 [Cheng Pan] [KYUUBI apache#5975][FOLLOWUP][TEST] Fix trino - get type info

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Mar 21, 2024
# 🔍 Description
## Issue References 🔗

This is a regular dependency upgrading,

## Describe Your Solution 🔧

Upgrade `trino-client` from 363 to 411. 411 is the latest version which uses okhttp 3.x, hence it does not have kotlin runtime dependencies.

This PR also updates the docs, especially the Trino cluster version requirement.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5975 from pan3793/trino-411.

Closes apache#5975

2b57df3 [Cheng Pan] fix
c498a5b [Cheng Pan] fix
21948ca [Cheng Pan] Fix compile
e4f1397 [Cheng Pan] license
66583ca [Cheng Pan] Bump trino-client 411

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Mar 21, 2024
# 🔍 Description
## Issue References 🔗

This pull request fixes the UT

## Describe Your Solution 🔧

Trino 411 adds now data types, the UT should be updated accordingly.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

And pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5979 from pan3793/5975-followup.

Closes apache#5975

832a482 [Cheng Pan] [KYUUBI apache#5975][FOLLOWUP][TEST] Fix trino - get type info

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
@pan3793 pan3793 deleted the trino-411 branch June 6, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:build kind:documentation Documentation is a feature! kind:infra license, community building, project builds, asf infra related, etc. module:integration-tests module:server module:spark module:trino
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants