-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #5991] Error on reading Atlas properties composed of multi values #5993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #5991 |
thanks for your contribution, please run |
pan3793
reviewed
Jan 18, 2024
...neage/src/main/scala/org/apache/kyuubi/plugin/lineage/dispatcher/atlas/AtlasClientConf.scala
Outdated
Show resolved
Hide resolved
pan3793
changed the title
fix 5991--kyuubi failed to read atlas.rest.address
[KYUUBI #5991] Error on reading Atlas properties composed of multi values
Jan 18, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5993 +/- ##
============================================
- Coverage 61.11% 61.07% -0.05%
Complexity 23 23
============================================
Files 622 623 +1
Lines 37043 37145 +102
Branches 5025 5033 +8
============================================
+ Hits 22640 22685 +45
- Misses 11958 12009 +51
- Partials 2445 2451 +6 ☔ View full report in Codecov by Sentry. |
pan3793
approved these changes
Feb 2, 2024
wForget
approved these changes
Feb 2, 2024
pan3793
pushed a commit
that referenced
this pull request
Feb 6, 2024
…lues # 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #5993 from SwordyZhao/fix-issues-5991. Closes #5991 827007d [swordy_zhao] run dev/reformat fix code style. 600363d [swordy_zhao] delete scala.List,Convert a java.List to scala.List 7b000e9 [swordy_zhao] fix 5991--kyuubi failed to read atlas.rest.address 5de0576 [swordy_zhao] fix 5991--kyuubi failed to read atlas.rest.address Authored-by: swordy_zhao <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 97f7987) Signed-off-by: Cheng Pan <[email protected]>
Merged to master/1.8 |
pan3793
pushed a commit
that referenced
this pull request
Feb 17, 2024
…lues # 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #5993 from SwordyZhao/fix-issues-5991. Closes #5991 827007d [swordy_zhao] run dev/reformat fix code style. 600363d [swordy_zhao] delete scala.List,Convert a java.List to scala.List 7b000e9 [swordy_zhao] fix 5991--kyuubi failed to read atlas.rest.address 5de0576 [swordy_zhao] fix 5991--kyuubi failed to read atlas.rest.address Authored-by: swordy_zhao <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 97f7987) Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…lti values # 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5993 from SwordyZhao/fix-issues-5991. Closes apache#5991 827007d [swordy_zhao] run dev/reformat fix code style. 600363d [swordy_zhao] delete scala.List,Convert a java.List to scala.List 7b000e9 [swordy_zhao] fix 5991--kyuubi failed to read atlas.rest.address 5de0576 [swordy_zhao] fix 5991--kyuubi failed to read atlas.rest.address Authored-by: swordy_zhao <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.