Fix RESTful protocol security enabled evaluation #6001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
pan3793
changed the title
|
Merged to master/1.8 |
pan3793
added a commit
that referenced
this pull request
Jan 19, 2024
#5568 (comment) Only when Kerberos is enabled or effectivePlainAuthType is not NONE, RESTful security is enabled - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) when `kyuubi.authentication=KERBEROS` and use RESTful API, the exception is thrown `AuthenticationException("Kerberos is not supported for thrift http mode")` when `kyuubi.authentication=KERBEROS`, the RESTful API uses SPNego authN. Add some `*KyuubiRestFrontendServiceSuite` --- - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6001 from pan3793/auth-krb. Closes #6001 3640424 [Cheng Pan] nit 69d33fb [Cheng Pan] fix f18cf84 [Cheng Pan] Fix RESTful security enabled evaluation Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Feb 5, 2024
# 🔍 Description ## Issue References 🔗 apache#5568 (comment) ## Describe Your Solution 🔧 Only when Kerberos is enabled or effectivePlainAuthType is not NONE, RESTful security is enabled ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ when `kyuubi.authentication=KERBEROS` and use RESTful API, the exception is thrown `AuthenticationException("Kerberos is not supported for thrift http mode")` #### Behavior With This Pull Request 🎉 when `kyuubi.authentication=KERBEROS`, the RESTful API uses SPNego authN. #### Related Unit Tests Add some `*KyuubiRestFrontendServiceSuite` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6001 from pan3793/auth-krb. Closes apache#6001 3640424 [Cheng Pan] nit 69d33fb [Cheng Pan] fix f18cf84 [Cheng Pan] Fix RESTful security enabled evaluation Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 apache#5568 (comment) ## Describe Your Solution 🔧 Only when Kerberos is enabled or effectivePlainAuthType is not NONE, RESTful security is enabled ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ when `kyuubi.authentication=KERBEROS` and use RESTful API, the exception is thrown `AuthenticationException("Kerberos is not supported for thrift http mode")` #### Behavior With This Pull Request 🎉 when `kyuubi.authentication=KERBEROS`, the RESTful API uses SPNego authN. #### Related Unit Tests Add some `*KyuubiRestFrontendServiceSuite` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6001 from pan3793/auth-krb. Closes apache#6001 3640424 [Cheng Pan] nit 69d33fb [Cheng Pan] fix f18cf84 [Cheng Pan] Fix RESTful security enabled evaluation Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
#5568 (comment)
Describe Your Solution 🔧
Only when Kerberos is enabled or effectivePlainAuthType is not NONE, RESTful security is enabled
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
when
kyuubi.authentication=KERBEROSand use RESTful API, the exception is thrownAuthenticationException("Kerberos is not supported for thrift http mode")Behavior With This Pull Request 🎉
when
kyuubi.authentication=KERBEROS, the RESTful API uses SPNego authN.Related Unit Tests
Add some
*KyuubiRestFrontendServiceSuiteChecklist 📝
Be nice. Be informative.