-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESTful API supports killing engine forcibly #6008
Closed
+148
−23
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
5faa5b5
kill engine forcibly
zhaohehuhu f3ab9c5
new parameter added to decide whether to kill forcefully
zhaohehuhu d6f82ff
refactor code
zhaohehuhu 8a65cf1
refactor code
zhaohehuhu f11e765
add an UT
zhaohehuhu 51827ec
fix UT
zhaohehuhu 070aad0
refactor
zhaohehuhu fb9b251
add default value for forceKill param
zhaohehuhu bd7bb45
refactor
zhaohehuhu 632c56b
fix unused import
zhaohehuhu 3ad9577
rename params to support multiple engines
zhaohehuhu 5062206
get refId by user, sharelevel and subdomain
zhaohehuhu 513bcdc
fix UT
zhaohehuhu ab31382
reformat
zhaohehuhu 634ceb6
reformat
zhaohehuhu ba57c2c
refactor code to delete the node and then kill application
zhaohehuhu 11106d7
comments
turboFei 9bacc2c
fix UTs
zhaohehuhu 936a54e
register app mgr info
turboFei ae24ea7
refactor UT
zhaohehuhu 3a2f597
refactor
zhaohehuhu a13466e
update doc and log string encoded
zhaohehuhu f826d05
reformat
zhaohehuhu 0cdeede
restore ENGINE_SPARK_REGISTER_ATTRIBUTES
zhaohehuhu b013194
move the position of log
zhaohehuhu 6d5d087
Update kyuubi-server/src/main/scala/org/apache/kyuubi/engine/Applicat…
pan3793 72d7df3
Update kyuubi-server/src/main/scala/org/apache/kyuubi/engine/Applicat…
pan3793 5e1b6a1
Update kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/A…
pan3793 cd5129d
fix ut
pan3793 efc7587
client
pan3793 8721a2d
log
pan3793 00c208a
fix
pan3793 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3546,10 +3546,7 @@ object KyuubiConf { | |
.toSequence() | ||
.createWithDefault(Seq( | ||
"spark.driver.memory", | ||
"spark.executor.memory", | ||
"spark.kubernetes.context", | ||
"spark.kubernetes.namespace", | ||
"spark.master")) | ||
"spark.executor.memory")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. restore There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Format issue. Restored. |
||
|
||
val ENGINE_SPARK_INITIALIZE_SQL: ConfigEntry[Seq[String]] = | ||
buildConf("kyuubi.engine.spark.initialize.sql") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's mention the default value is false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.