-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce service stop graceful period to prevent stuck because of active connections #6020
Conversation
while (backendService.sessionManager.getOpenSessionCount > 0) { | ||
Thread.sleep(1000 * 60) | ||
} | ||
info(s"Spark engine has no open session now, terminating.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated, so I remove it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6020 +/- ##
============================================
- Coverage 61.16% 61.13% -0.04%
Complexity 23 23
============================================
Files 623 623
Lines 37060 37061 +1
Branches 5024 5024
============================================
- Hits 22669 22657 -12
- Misses 11956 11965 +9
- Partials 2435 2439 +4 ☔ View full report in Codecov by Sentry. |
🔍 Description
Issue References 🔗
This pr introduce service stop graceful period to prevent stuck because of active connections.
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.