Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce service stop graceful period to prevent stuck because of active connections #6020

Closed
wants to merge 6 commits into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Jan 25, 2024

🔍 Description

Issue References 🔗

This pr introduce service stop graceful period to prevent stuck because of active connections.

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

while (backendService.sessionManager.getOpenSessionCount > 0) {
Thread.sleep(1000 * 60)
}
info(s"Spark engine has no open session now, terminating.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated, so I remove it.

@turboFei turboFei changed the title shutdown when stop Introduce service stop graceful period to prevent stuck because of active connections Jan 25, 2024
@turboFei turboFei requested review from hddong, cxzl25 and pan3793 January 25, 2024 18:46
@turboFei turboFei marked this pull request as draft January 25, 2024 19:11
@turboFei turboFei self-assigned this Jan 25, 2024
@turboFei turboFei marked this pull request as ready for review January 25, 2024 19:31
@turboFei turboFei closed this Jan 25, 2024
@turboFei turboFei reopened this Jan 25, 2024
@turboFei turboFei marked this pull request as draft January 25, 2024 21:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47a1091) 61.16% compared to head (3468b23) 61.13%.

❗ Current head 3468b23 differs from pull request most recent head 3b177eb. Consider uploading reports for the commit 3b177eb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6020      +/-   ##
============================================
- Coverage     61.16%   61.13%   -0.04%     
  Complexity       23       23              
============================================
  Files           623      623              
  Lines         37060    37061       +1     
  Branches       5024     5024              
============================================
- Hits          22669    22657      -12     
- Misses        11956    11965       +9     
- Partials       2435     2439       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turboFei turboFei closed this Feb 5, 2024
@turboFei turboFei deleted the npe_fix branch February 5, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants