Fix the JDBC engine provider name

[silencily]

🔍 Description

Issue References 🔗

This pull request fixes create Jdbc Engine error:

 java.lang.IllegalArgumentException: Could not find a JDBC connection provider with name 'org.apache.kyuubi.engine.jdbc.mysql.MySQLConnectionProvider' that can handle the specified driver and options. Available providers are [org.apache.kyuubi.engine.jdbc.doris.DorisConnectionProvider@57459491, org.apache.kyuubi.engine.jdbc.mysql.MySQLConnectionProvider@dcfda20, org.apache.kyuubi.engine.jdbc.phoenix.PhoenixConnectionProvider@5c87bfe2, org.apache.kyuubi.engine.jdbc.postgresql.PostgreSQLConnectionProvider@51cd7ffc, org.apache.kyuubi.engine.jdbc.starrocks.StarRocksConnectionProvider@40f1be1b]

Describe Your Solution 🔧

  val ENGINE_JDBC_CONNECTION_PROVIDER: OptionalConfigEntry[String] =
    buildConf("kyuubi.engine.jdbc.connection.provider")
      .doc("A JDBC connection provider plugin for the Kyuubi Server " +
        "to establish a connection to the JDBC URL." +
        " The configuration value should be a subclass of " +
        "`org.apache.kyuubi.engine.jdbc.connection.JdbcConnectionProvider`. " +
        "Kyuubi provides the following built-in implementations: " +
        "<li>doris: For establishing Doris connections.</li> " +
        "<li>mysql: For establishing MySQL connections.</li> " +
        "<li>phoenix: For establishing Phoenix connections.</li> " +
        "<li>postgresql: For establishing PostgreSQL connections.</li>" +
        "<li>starrocks: For establishing StarRocks connections.</li>")
      .version("1.6.0")
      .stringConf
      .transform {
        case "Doris" | "doris" | "DorisConnectionProvider" =>
          "org.apache.kyuubi.engine.jdbc.doris.DorisConnectionProvider"
        case "MySQL" | "mysql" | "MySQLConnectionProvider" =>
          "org.apache.kyuubi.engine.jdbc.mysql.MySQLConnectionProvider"
        case "Phoenix" | "phoenix" | "PhoenixConnectionProvider" =>
          "org.apache.kyuubi.engine.jdbc.phoenix.PhoenixConnectionProvider"
        case "PostgreSQL" | "postgresql" | "PostgreSQLConnectionProvider" =>
          "org.apache.kyuubi.engine.jdbc.postgresql.PostgreSQLConnectionProvider"
        case "StarRocks" | "starrocks" | "StarRocksConnectionProvider" =>
          "org.apache.kyuubi.engine.jdbc.starrocks.StarRocksConnectionProvider"
        case other => other
      }
      .createOptional

because the provider name transforms the fully qualified class name, but class simple name is compared

Types of changes 🔖

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

I have passed this pull request at local integration testing

Related Unit Tests

---

Checklist 📝

• This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (208354c) 61.18% compared to head (35b3dc7) 61.10%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6037      +/-   ##
============================================
- Coverage     61.18%   61.10%   -0.08%     
  Complexity       23       23              
============================================
  Files           623      623              
  Lines         37144    37145       +1     
  Branches       5032     5033       +1     
============================================
- Hits          22726    22698      -28     
- Misses        11976    11998      +22     
- Partials       2442     2449       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pan3793]

LGTM, thanks for fixing this. Does it affect branch-1.8 too?

[silencily]

LGTM, thanks for fixing this. Does it affect branch-1.8 too?

It does not affect branch-1.8, this bug is caused by pull request #5464

[pan3793]

Thanks, merged to master