Bump Kyuubi Shaded 0.3.0 #6117
Closed
Bump Kyuubi Shaded 0.3.0 #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:server
module:hive
module:ctl
module:common
kind:build
labels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6117 +/- ##
============================================
- Coverage 61.13% 61.01% -0.13%
+ Complexity 24 23 -1
============================================
Files 625 623 -2
Lines 37263 37177 -86
Branches 5046 5039 -7
============================================
- Hits 22781 22683 -98
- Misses 12020 12035 +15
+ Partials 2462 2459 -3 ☔ View full report in Codecov by Sentry. |
|
@SteNicholas after two years, I'd like to re-attempt this upgrading to address CVEs #1953 |
|
also cc @zhouyifan279 |
zhouyifan279
approved these changes
Mar 7, 2024
|
LGTM |
SteNicholas
reviewed
Mar 8, 2024
| errMsg.contains(s"Socket for ${SessionHandle(handle)} is closed")) | ||
| errMsg.contains(s"Socket for ${SessionHandle(handle)} is closed") || | ||
| errMsg.contains("Socket is closed by peer") || | ||
| errMsg.contains("SparkContext was shut down")) |
There was a problem hiding this comment.
Could the errMsg contain Broken pipe (Write failed)?
There was a problem hiding this comment.
I think no, because the error is likely occurs on reading
SteNicholas
approved these changes
Mar 8, 2024
|
Thanks, merging to master |
zhouyifan279
pushed a commit
to zhouyifan279/kyuubi
that referenced
this pull request
Mar 11, 2024
# 🔍 Description ## Issue References 🔗 This PR upgrades Kyuubi Shaded to 0.3.0, the major changes are: - upgrade Thrift from 0.9.3-1 to 0.16.0 - upgrade JLine used by Zookeeper CLI from 0.9.94 to 2.14.6 - split kyuubi-relocated-thrift from kyuubi-relocated-hive-service-rpc - introduce a light kyuubi-relocated-hive-metastore-client for getting DelegationToken Due to THRIFT-5297 (fixed in 0.14.0) removes requestTimeout and beBackoffSlotLength, the following Kyuubi configurations are removed too. - kyuubi.frontend.login.timeout - kyuubi.frontend.thrift.login.timeout - kyuubi.frontend.backoff.slot.length - kyuubi.frontend.thrift.backoff.slot.length Previously, Zookeeper 3.4 depends on JLine 0.9.94 while Zookeeper 3.6 and Hive Beeline depends on JLine 2.14.6, we pulls different versions of JLine into the binary distribution. Now we align them to a single JLine 2.14.6. ## Describe Your Solution 🔧 Upgrade dependencies and change code to adapt to the breaking changes, also upgrade migration guide to mention the removed configurations. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass GA. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6117 from pan3793/shaded-0.3. Closes apache#6117 5639c9f [Cheng Pan] nit d281cdb [Cheng Pan] fix 184e1b9 [Cheng Pan] fix 1628337 [Cheng Pan] remove unused conf 24db2d5 [Cheng Pan] try fix 1e995bb [Cheng Pan] nit 1d8e9bc [Cheng Pan] dep list 7f33624 [Cheng Pan] Bump Kyuubi Shaded 0.3.0 Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This PR upgrades Kyuubi Shaded to 0.3.0, the major changes are: - upgrade Thrift from 0.9.3-1 to 0.16.0 - upgrade JLine used by Zookeeper CLI from 0.9.94 to 2.14.6 - split kyuubi-relocated-thrift from kyuubi-relocated-hive-service-rpc - introduce a light kyuubi-relocated-hive-metastore-client for getting DelegationToken Due to THRIFT-5297 (fixed in 0.14.0) removes requestTimeout and beBackoffSlotLength, the following Kyuubi configurations are removed too. - kyuubi.frontend.login.timeout - kyuubi.frontend.thrift.login.timeout - kyuubi.frontend.backoff.slot.length - kyuubi.frontend.thrift.backoff.slot.length Previously, Zookeeper 3.4 depends on JLine 0.9.94 while Zookeeper 3.6 and Hive Beeline depends on JLine 2.14.6, we pulls different versions of JLine into the binary distribution. Now we align them to a single JLine 2.14.6. ## Describe Your Solution 🔧 Upgrade dependencies and change code to adapt to the breaking changes, also upgrade migration guide to mention the removed configurations. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass GA. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6117 from pan3793/shaded-0.3. Closes apache#6117 5639c9f [Cheng Pan] nit d281cdb [Cheng Pan] fix 184e1b9 [Cheng Pan] fix 1628337 [Cheng Pan] remove unused conf 24db2d5 [Cheng Pan] try fix 1e995bb [Cheng Pan] nit 1d8e9bc [Cheng Pan] dep list 7f33624 [Cheng Pan] Bump Kyuubi Shaded 0.3.0 Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This PR upgrades Kyuubi Shaded to 0.3.0, the major changes are:
Due to THRIFT-5297 (fixed in 0.14.0) removes requestTimeout and beBackoffSlotLength, the following Kyuubi configurations are removed too.
Previously, Zookeeper 3.4 depends on JLine 0.9.94 while Zookeeper 3.6 and Hive Beeline depends on JLine 2.14.6, we pulls different versions of JLine into the binary distribution. Now we align them to a single JLine 2.14.6.
Describe Your Solution 🔧
Upgrade dependencies and change code to adapt to the breaking changes, also upgrade migration guide to mention the removed configurations.
Types of changes 🔖
Test Plan 🧪
Pass GA.
Checklist 📝
Be nice. Be informative.