Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trino create client session should use engine seesion user #6120

Closed
wants to merge 1 commit into from

Conversation

lsm1
Copy link
Contributor

@lsm1 lsm1 commented Mar 1, 2024

🔍 Description

Issue References 🔗

In engine share level such as SERVER, KYUUBI_SESSION_USER_KEY is a fixed value, we should use the engine session user as the trino client session user

Describe Your Solution 🔧

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.22%. Comparing base (2c9fb3d) to head (4393183).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6120      +/-   ##
============================================
+ Coverage     61.12%   61.22%   +0.09%     
  Complexity       23       23              
============================================
  Files           623      623              
  Lines         37200    37485     +285     
  Branches       5040     5077      +37     
============================================
+ Hits          22738    22949     +211     
- Misses        12001    12075      +74     
  Partials       2461     2461              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxzl25 cxzl25 modified the milestones: v1.8.2, v1.9.0 Mar 1, 2024
@cxzl25 cxzl25 requested a review from pan3793 March 4, 2024 03:27
@pan3793
Copy link
Member

pan3793 commented Mar 4, 2024

In engine share level such as SERVER, KYUUBI_SESSION_USER_KEY is a fixed value

this seems not an expected behavior, will take a look later

@pan3793
Copy link
Member

pan3793 commented Mar 7, 2024

The issue should be val sessionConf: KyuubiConf = sessionManager.getConf, it's actually an engine level conf, but we expect a session level conf.

@pan3793
Copy link
Member

pan3793 commented Mar 8, 2024

This issue should be fixed in an alternative approach #6148

@pan3793 pan3793 closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants