Drop Kyuubi extension for Spark 3.1 #6125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
pan3793
commented
Mar 4, 2024
| <!-- | ||
| Spark requires `commons-collections` and `commons-io` but got them from transitive | ||
| dependencies of `hadoop-client`. As we are using Hadoop Shaded Client, we need add | ||
| them explicitly. See more details at SPARK-33212. |
There was a problem hiding this comment.
SPARK-33212 gets fixed in Spark 3.2, we don't need such workaround now
wForget
reviewed
Mar 4, 2024
| .version("1.2.0") | ||
| .intConf | ||
| .createOptional | ||
|
|
||
| val DYNAMIC_PARTITION_INSERTION_REPARTITION_NUM = |
There was a problem hiding this comment.
thanks for checking. you are right, removed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6125 +/- ##
============================================
- Coverage 61.22% 61.18% -0.05%
Complexity 23 23
============================================
Files 624 624
Lines 37247 37247
Branches 5042 5042
============================================
- Hits 22806 22790 -16
- Misses 11991 12001 +10
- Partials 2450 2456 +6 ☔ View full report in Codecov by Sentry. |
ulysses-you
approved these changes
Mar 5, 2024
wForget
approved these changes
Mar 5, 2024
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This pull request is the next step of deprecating and removing support of Spark 3.1 VOTE: https://lists.apache.org/thread/670fx1qx7rm0vpvk8k8094q2d0fthw5b VOTE RESULT: https://lists.apache.org/thread/0zdxg5zjnc1wpxmw9mgtsxp1ywqt6qvb ## Describe Your Solution 🔧 Drop module `kyuubi-extension-spark-3-1` and delete Spark 3.1 specific codes. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass GA. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6125 from pan3793/drop-spark-ext-3-1. Closes apache#6125 212012f [Cheng Pan] fix style 021532c [Cheng Pan] doc 329f69a [Cheng Pan] address comments 43fac42 [Cheng Pan] fix a12c806 [Cheng Pan] fix dcf51c1 [Cheng Pan] minor 814a187 [Cheng Pan] Drop Kyuubi extension for Spark 3.1 Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request is the next step of deprecating and removing support of Spark 3.1
VOTE: https://lists.apache.org/thread/670fx1qx7rm0vpvk8k8094q2d0fthw5b
VOTE RESULT: https://lists.apache.org/thread/0zdxg5zjnc1wpxmw9mgtsxp1ywqt6qvb
Describe Your Solution 🔧
Drop module
kyuubi-extension-spark-3-1and delete Spark 3.1 specific codes.Types of changes 🔖
Test Plan 🧪
Pass GA.
Checklist 📝
Be nice. Be informative.