[KYUUBI #6126] Filter blank engine home env #6127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Mar 5, 2024
pan3793
reviewed
Mar 5, 2024
cxzl25
approved these changes
Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6127 +/- ##
============================================
- Coverage 61.15% 61.11% -0.05%
Complexity 23 23
============================================
Files 624 624
Lines 37247 37247
Branches 5042 5042
============================================
- Hits 22780 22762 -18
- Misses 12014 12019 +5
- Partials 2453 2466 +13 ☔ View full report in Codecov by Sentry. |
|
Thanks, merged to master/1.8 |
pan3793
pushed a commit
that referenced
this pull request
Mar 6, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes #6126 ## Describe Your Solution 🔧 Filter blank engine home env ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6127 from wForget/KYUUBI-6126. Closes #6126 a42a8a6 [wforget] fix typo 55d2bfc [wforget] [KYUUBI-6126] Filter blank engine home env Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 9e7f2d0) Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#6126 ## Describe Your Solution 🔧 Filter blank engine home env ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6127 from wForget/KYUUBI-6126. Closes apache#6126 a42a8a6 [wforget] fix typo 55d2bfc [wforget] [KYUUBI-6126] Filter blank engine home env Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
beryllw
pushed a commit
to beryllw/incubator-kyuubi
that referenced
this pull request
Jun 7, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#6126 ## Describe Your Solution 🔧 Filter blank engine home env ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6127 from wForget/KYUUBI-6126. Closes apache#6126 a42a8a6 [wforget] fix typo 55d2bfc [wforget] [KYUUBI-6126] Filter blank engine home env Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 9e7f2d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #6126
Describe Your Solution 🔧
Filter blank engine home env
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.