-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Remove the extension spark jars before build to avoid include unspecified version #6129
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6129 +/- ##
============================================
- Coverage 61.17% 61.15% -0.02%
Complexity 23 23
============================================
Files 624 624
Lines 37260 37260
Branches 5046 5046
============================================
- Hits 22793 22788 -5
- Misses 12011 12021 +10
+ Partials 2456 2451 -5 ☔ View full report in Codecov by Sentry. |
After second thought, we should still do this in script to avoid trigger the clean logic multi times. |
37e05cb
to
d824491
Compare
Thanks, merged to master |
…uild to avoid include unspecified version # 🔍 Description ## Issue References 🔗 This pull request fixes apache#5836 (comment) ## Describe Your Solution 🔧 Remove the remain extension spark jars in related target dir before start to package. Aims to avoid include unspecified version. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Before this PR: ```shel ./build/dist -Pspark-3.1 ... # your will get expected package, then you run the following command ./build/dist -Pspark-3.3 # you will find the final package include the spark 3.1 extension jar, which is un-expected. ``` #### Behavior With This Pull Request 🎉 After this PR, will clean up those extension spark jars before build to ensure we won't package the unspecified extension jar. #### Related Unit Tests None --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6129 from zwangsheng/KYUUBI/clean_up_jasrs. Closes apache#6129 3e5f434 [Cheng Pan] Update build/dist d824491 [zwangsheng] Remove support spark 3.1 c83b79a [zwangsheng] [BUILD] Remove the extension spark jars before build Lead-authored-by: zwangsheng <[email protected]> Co-authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
🔍 Description
Issue References 🔗
This pull request fixes #5836 (comment)
Describe Your Solution 🔧
Remove the remain extension spark jars in related target dir before start to package.
Aims to avoid include unspecified version.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Before this PR:
Behavior With This Pull Request 🎉
After this PR, will clean up those extension spark jars before build to ensure we won't package the unspecified extension jar.
Related Unit Tests
None
Checklist 📝
Be nice. Be informative.