[KYUUBI #6134] Support Flink 1.19 #6141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:infra
wForget
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6141 +/- ##
============================================
- Coverage 61.18% 61.01% -0.18%
Complexity 24 24
============================================
Files 625 625
Lines 37234 37208 -26
Branches 5028 5028
============================================
- Hits 22782 22702 -80
- Misses 12011 12054 +43
- Partials 2441 2452 +11 ☔ View full report in Codecov by Sentry. |
wForget
commented
Mar 8, 2024
| @@ -993,6 +993,8 @@ abstract class FlinkOperationSuite extends HiveJDBCTestHelper with WithFlinkTest | |||
| statement.getConnection.setSchema("db_a") | |||
| val changedSchema = statement.getConnection.getSchema | |||
| assert(changedSchema == "db_a") | |||
| // reset database to default | |||
| statement.getConnection.setSchema("default_database") | |||
There was a problem hiding this comment.
Flink 1.19 has the following limitations:
Cannot drop a database which is currently in use.
|
The final Flink 1.19 VOTE pass is likely to happen after the Kyuubi 1.9 VOTE starts, as Flink 1.19 already entered the RC2 phase, the API should be stable. To make the Flink 1.19 support be included in Kyuubi 1.9, can we merge the code change first and leave tests until the Flink 1.19 official release available? |
SGTM, CI (https://github.com/apache/kyuubi/actions/runs/8198173643) has run successfully, let us remove the CI and profile of flink 1.19 first |
wForget
changed the title
github-actions
bot
removed
kind:infra
pan3793
approved these changes
Mar 11, 2024
|
OK, I merged the code change to the master first, please open another PR for supplying CI and continuous RC testing. |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#6134 ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6141 from wForget/KYUUBI-6134. Closes apache#6134 c8ee7f0 [wforget] remove flink-1.19.0-rc2 resource and flink 1.19 ga efb3d8a [wforget] fix 845b27f [wforget] fix 08b8b1d [wforget] dev c9f6917 [wforget] fix b93744d [wforget] [KYUUBI apache#6134] Support Flink 1.19 Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
beryllw
pushed a commit
to beryllw/incubator-kyuubi
that referenced
this pull request
Jun 7, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#6134 ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6141 from wForget/KYUUBI-6134. Closes apache#6134 c8ee7f0 [wforget] remove flink-1.19.0-rc2 resource and flink 1.19 ga efb3d8a [wforget] fix 845b27f [wforget] fix 08b8b1d [wforget] dev c9f6917 [wforget] fix b93744d [wforget] [KYUUBI apache#6134] Support Flink 1.19 Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 78e56af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #6134
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.