Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke setStopAtShutdown for jetty server #6150

Closed
wants to merge 1 commit into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Mar 8, 2024

🔍 Description

Issue References 🔗

Invoke org.eclipse.jetty.server.Server::setStopAtShutdown

    /**
     * Set stop server at shutdown behaviour.
     *
     * @param stop If true, this server instance will be explicitly stopped when the
     * JVM is shutdown. Otherwise the JVM is stopped with the server running.
     * @see Runtime#addShutdownHook(Thread)
     * @see ShutdownThread
     */
    public void setStopAtShutdown(boolean stop)

Describe Your Solution 🔧

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@turboFei turboFei changed the title setStopAtShutdown Invoke setStopAtShutdown for jetty server Mar 8, 2024
@turboFei turboFei self-assigned this Mar 8, 2024
@pan3793
Copy link
Member

pan3793 commented Mar 11, 2024

This adds a shutdown hook to close the Jetty server, actually, Kyuubi also adds shutdown hooks to close all frontend services and recursively close the Jetty server. So is it necessary?

@turboFei
Copy link
Member Author

This adds a shutdown hook to close the Jetty server, actually, Kyuubi also adds shutdown hooks to close all frontend services and recursively close the Jetty server. So is it necessary?

Make senses, will close it.

@turboFei turboFei closed this Mar 11, 2024
@turboFei turboFei deleted the shutdown branch March 11, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants