Cut out Hive JDBC and Hive Service deps in beeline module #6153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:infra
4 tasks
pan3793
requested review from
ulysses-you and
cfmcgrady
and removed request for
ulysses-you
ulysses-you
reviewed
Mar 11, 2024
| @@ -40,7 +41,7 @@ | |||
| * <client-principal> | |||
| */ | |||
| public class ProxyAuthTest { | |||
| private static final String driverName = "org.apache.hive.jdbc.HiveDriver"; | |||
| private static final String driverName = "org.apache.kyuubi.jdbc.KyuubiHiveDriver"; | |||
There was a problem hiding this comment.
we still support org.apache.hive.jdbc.HiveDriver right ?
There was a problem hiding this comment.
I think we have no such guarantee, the internally used JDBC driver is not user-faced stuff, we only need to ensure that user could smoothly migrate from Hive Beeline to Kyuubi Beeline without changing the JDBC URL.
|
lgtm if tests pass |
|
Thanks, merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…ne module # 🔍 Description ## Issue References 🔗 This is the next step of apache#6146, cutting out most Hive deps(excepting `hive-common`) and recovering the skipped tests via minor code tunning. ## Describe Your Solution 🔧 - Drop `hive-jdbc`, `hive-service`, `hive-service-rpc` deps in the beeline module. - Migrate from `commons-lang` to `commons-lang3` in the beeline module. - Recover the skipped test `TestClientCommandHookFactory#connectHook` ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass GA, and manually test to ensure the following error has gone. Before ``` roothadoop-master1:/opt/kyuubi# bin/beeline --version Warn: Not find kyuubi environment file /etc/kyuubi/conf/kyuubi-env.sh, using default ones... java.lang.NoClassDefFoundError: org/apache/curator/RetryPolicy ``` After ``` roothadoop-master1:/opt/kyuubi# bin/beeline --version Connecting to jdbc:hive2://hadoop-master1.orb.local:10000/default;password=hive;user=hive Connected to: Apache Hive (version 2.3.9) Driver: Kyuubi Project Hive JDBC Client (version 1.9.0-SNAPSHOT) Beeline version 1.9.0-SNAPSHOT by Apache Kyuubi 0: jdbc:hive2://hadoop-master1.orb.local:1000> ``` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6153 from pan3793/beeline-2. Closes apache#6153 8cd52e5 [Cheng Pan] notice d03c729 [Cheng Pan] minor 5d16bf4 [Cheng Pan] beeline test pass Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This is the next step of #6146, cutting out most Hive deps(excepting
hive-common) and recovering the skipped tests via minor code tunning.Describe Your Solution 🔧
hive-jdbc,hive-service,hive-service-rpcdeps in the beeline module.commons-langtocommons-lang3in the beeline module.TestClientCommandHookFactory#connectHookTypes of changes 🔖
Test Plan 🧪
Pass GA, and manually test to ensure the following error has gone.
Before
After
Checklist 📝
Be nice. Be informative.