[KYUUBI #6156] Remove flink. prefix for create session configurations
#6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wForget
changed the title
flink. prefix for create session configurationsflink. prefix for create session configurations
wForget
changed the title
flink. prefix for create session configurationsflink. prefix for create session configurations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6157 +/- ##
============================================
- Coverage 58.73% 58.73% -0.01%
Complexity 24 24
============================================
Files 663 663
Lines 40685 40685
Branches 5594 5594
============================================
- Hits 23898 23897 -1
+ Misses 14169 14165 -4
- Partials 2618 2623 +5 ☔ View full report in Codecov by Sentry. |
yaooqinn
approved these changes
Mar 12, 2024
pan3793
reviewed
Mar 12, 2024
...ql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSQLSessionManager.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Mar 12, 2024
link3280
approved these changes
Mar 12, 2024
pan3793
pushed a commit
that referenced
this pull request
Mar 12, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes #6156 ## Describe Your Solution 🔧 Remove `flink.` prefix for open flink session configurations. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6157 from wForget/KYUUBI-6156. Closes #6156 fc750dc [wforget] comment f613491 [wforget] Remove `flink.` prefix for create session configurations Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 7562a97) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.8 |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…urations # 🔍 Description ## Issue References 🔗 This pull request fixes apache#6156 ## Describe Your Solution 🔧 Remove `flink.` prefix for open flink session configurations. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6157 from wForget/KYUUBI-6156. Closes apache#6156 fc750dc [wforget] comment f613491 [wforget] Remove `flink.` prefix for create session configurations Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
beryllw
pushed a commit
to beryllw/incubator-kyuubi
that referenced
this pull request
Jun 7, 2024
…urations # 🔍 Description ## Issue References 🔗 This pull request fixes apache#6156 ## Describe Your Solution 🔧 Remove `flink.` prefix for open flink session configurations. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6157 from wForget/KYUUBI-6156. Closes apache#6156 fc750dc [wforget] comment f613491 [wforget] Remove `flink.` prefix for create session configurations Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 7562a97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #6156
Describe Your Solution 🔧
Remove
flink.prefix for open flink session configurations.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.