[MINOR] Remove confusing variable #6158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Mar 11, 2024
...ql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSQLSessionManager.scala
Outdated
Show resolved
Hide resolved
wForget
changed the title
wForget
changed the title
pan3793
approved these changes
Mar 11, 2024
pan3793
pushed a commit
that referenced
this pull request
Mar 11, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 `fSession` refers more to `FlinkSessionImpl.fSession`. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6158 from wForget/hotfix. Closes #6158 b388b9f [wforget] fix 51bc0c5 [wforget] comment 83ed8d2 [wforget] [MINOR] Fix confusing variable name Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 4def333) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.8 |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 `fSession` refers more to `FlinkSessionImpl.fSession`. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6158 from wForget/hotfix. Closes apache#6158 b388b9f [wforget] fix 51bc0c5 [wforget] comment 83ed8d2 [wforget] [MINOR] Fix confusing variable name Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
beryllw
pushed a commit
to beryllw/incubator-kyuubi
that referenced
this pull request
Jun 7, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 `fSession` refers more to `FlinkSessionImpl.fSession`. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6158 from wForget/hotfix. Closes apache#6158 b388b9f [wforget] fix 51bc0c5 [wforget] comment 83ed8d2 [wforget] [MINOR] Fix confusing variable name Authored-by: wforget <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 4def333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
fSessionrefers more toFlinkSessionImpl.fSession.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.