Cut out hive-common deps in beeline module #6162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:infra
4 tasks
pan3793
commented
Mar 11, 2024
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /* | ||
| * Looks for a hive-site.xml from the classpath. If found this class parses the hive-site.xml | ||
| * to return a set of connection properties which can be used to construct the connection url | ||
| * for Beeline connection | ||
| * | ||
| * This class is modified to get rid of dependency on HiveConf | ||
| */ | ||
| public class HiveSiteHS2ConnectionFileParser implements HS2ConnectionFileParser { |
There was a problem hiding this comment.
it's easy to extend the HS2ConnectionFileParser to make the beeline support auto-getting connection URL from kyuubi-defaults.conf, we should make such an extension in the future.
ulysses-you
approved these changes
Mar 12, 2024
|
@ulysses-you As we discussed offline, in case users may pull |
|
Thanks, merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This PR removes the `hive-common` dep from the beeline module, and it is the final step of cutting out all Hive deps from the beeline module. ## Describe Your Solution 🔧 - Remove support of Hive CLI mode (a.k.a. `beelineMode == false`) on beeline. - Copy ~7 classes (~600 lines) from `org.apache.hive:hive-common:3.1.3` - Drop `org.apache.hive:hive-common:3.1.3` from beeline module Note: Hive CLI mode removal is necessary, because it is useless for Kyuubi cases and seriously coupled with `HiveConf` ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass GA, and manually tested. ``` roothadoop-master1:/opt/kyuubi# beeline Connecting to jdbc:hive2://hadoop-master1.orb.local:10000/default;password=hive;user=hive Connected to: Apache Hive (version 2.3.9) Driver: Kyuubi Project Hive JDBC Client (version 1.9.0-SNAPSHOT) Beeline version 1.9.0-SNAPSHOT by Apache Kyuubi 0: jdbc:hive2://hadoop-master1.orb.local:1000> select version(); +--------------------------------------------------+ | _c0 | +--------------------------------------------------+ | 2.3.9 r92dd0159f440ca7863be3232f3a683a510a62b9d | +--------------------------------------------------+ 1 row selected (1.443 seconds) 0: jdbc:hive2://hadoop-master1.orb.local:1000> ``` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6162 from pan3793/beeline-3. Closes apache#6162 e85f096 [Cheng Pan] relocate b2ce8ef [Cheng Pan] Cut out hive-common deps in beeline module Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This PR removes the
hive-commondep from the beeline module, and it is the final step of cutting out all Hive deps from the beeline module.Describe Your Solution 🔧
beelineMode == false) on beeline.org.apache.hive:hive-common:3.1.3org.apache.hive:hive-common:3.1.3from beeline moduleNote: Hive CLI mode removal is necessary, because it is useless for Kyuubi cases and seriously coupled with
HiveConfTypes of changes 🔖
Test Plan 🧪
Pass GA, and manually tested.
Checklist 📝
Be nice. Be informative.