Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop building support for Flink 1.16 #6171

Closed
wants to merge 1 commit into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Mar 12, 2024

Description

We already marked the support for Flink 1.16 as deprecated, this PR drops the building support for Flink 1.16, while we still keep the cross-version verification to ensure the Flink engine still works on Flink 1.16 runtime.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Pass GA.


Checklist 📝

Be nice. Be informative.

@pan3793 pan3793 requested review from wForget and link3280 March 12, 2024 08:27
@pan3793 pan3793 self-assigned this Mar 12, 2024
@github-actions github-actions bot added kind:infra license, community building, project builds, asf infra related, etc. kind:build labels Mar 12, 2024
@pan3793 pan3793 added this to the v1.9.0 milestone Mar 12, 2024
@pan3793 pan3793 closed this in bc33e6a Mar 12, 2024
@pan3793
Copy link
Member Author

pan3793 commented Mar 12, 2024

Thanks, merged to master

pan3793 added a commit to pan3793/kyuubi that referenced this pull request Mar 13, 2024
pan3793 added a commit that referenced this pull request Mar 13, 2024
# 🔍 Description

I forgot the Flink cross-version verification integration tests require using the target Flink version to bootstrap a Flink Mini Cluster, this PR restores `flink-1.16` profile to recover Flink IT

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6176 from pan3793/6171-followup.

Closes #6171

f2ffcc9 [Cheng Pan] [KYUUBI #6171][FOLLOWUP] Restore flink-1.16 profile to recover Flink IT

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Mar 21, 2024
# Description

We already marked the support for Flink 1.16 as deprecated, this PR drops the building support for Flink 1.16, while we still keep the cross-version verification to ensure the Flink engine still works on Flink 1.16 runtime.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6171 from pan3793/drop-flink-116-profile.

Closes apache#6171

2dd74ec [Cheng Pan] Drop building support for Flink 1.16

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Mar 21, 2024
…Flink IT

# 🔍 Description

I forgot the Flink cross-version verification integration tests require using the target Flink version to bootstrap a Flink Mini Cluster, this PR restores `flink-1.16` profile to recover Flink IT

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6176 from pan3793/6171-followup.

Closes apache#6171

f2ffcc9 [Cheng Pan] [KYUUBI apache#6171][FOLLOWUP] Restore flink-1.16 profile to recover Flink IT

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
@pan3793 pan3793 deleted the drop-flink-116-profile branch June 6, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:build kind:infra license, community building, project builds, asf infra related, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants